Re: [PATCH 01/22] binutils, objdump: Add --ctf-parent-section

[Nick Alcock <nick.alcock@oracle.com>]

On 18 Apr 2024, Alan Modra said:

> On Wed, Apr 17, 2024 at 09:19:57PM +0100, Nick Alcock wrote:
>> @@ -4890,13 +4897,36 @@ dump_ctf (bfd *abfd, const char *sect_name, const char *parent_name)
>>        return;
>>      }
>>  
>> -  if ((parent = ctf_dict_open (ctfa, parent_name, &err)) == NULL)
>> +  if (parent_sect_name) {
>> +    psec = read_section (abfd, parent_sect_name, &ctfpdata);
>> +    if (sec == NULL) {
>> +      my_bfd_nonfatal (bfd_get_filename (abfd));
>> +      free (ctfdata);
>> +      return;
>> +    }
>
> Formatting, here and elsewhere in this patch.  Open braces go on a
> line by themselves.

AUGH. Apologies, will audit the whole series for this: I see several
others just from a quick grep (and a few leading space/tab problems too,
despite my having hooks trying to spot them). Doing simultaneous
development in OTBS and GNU-style codebases means I make these sorts of
mistakes *all the time* :/ and cc-mode, even with electric newlines,
doesn't always fix them for me.

> Patch is OK with these all fixed.

Thanks!

-- 
NULL && (void)