* Commit: Update description of bfd_fill_in_gnu_debuglink_section
@ 2023-02-21 11:14 Nick Clifton
0 siblings, 0 replies; only message in thread
From: Nick Clifton @ 2023-02-21 11:14 UTC (permalink / raw)
To: binutils
Hi Guys,
I am checking in the patch below to update the description of the
bfd_fill_in_gnu_debuglink_section function - which will perfectly
file with both relative filepaths and absolute filepaths.
The patch also fixes a comment, since the path to the binary file
is not significant for the link that is actually stored in the
.gnu_debuglink section.
Cheers
Nick
diff --git a/bfd/opncls.c b/bfd/opncls.c
index 4d0ca48ee78..5dacad9b7d4 100644
--- a/bfd/opncls.c
+++ b/bfd/opncls.c
@@ -1706,8 +1706,8 @@ SYNOPSIS
DESCRIPTION
Takes a @var{BFD} and containing a .gnu_debuglink section @var{SECT}
and fills in the contents of the section to contain a link to the
- specified @var{filename}. The filename should be relative to the
- current directory.
+ specified @var{filename}. The filename should be absolute or
+ relative to the current directory.
<<TRUE>> is returned if all is ok. Otherwise <<FALSE>> is returned
and bfd_error is set.
@@ -1733,12 +1733,7 @@ bfd_fill_in_gnu_debuglink_section (bfd *abfd,
return false;
}
- /* Make sure that we can read the file.
- XXX - Should we attempt to locate the debug info file using the same
- algorithm as gdb ? At the moment, since we are creating the
- .gnu_debuglink section, we insist upon the user providing us with a
- correct-for-section-creation-time path, but this need not conform to
- the gdb location algorithm. */
+ /* Open the linked file so that we can compute a CRC. */
handle = _bfd_real_fopen (filename, FOPEN_RB);
if (handle == NULL)
{
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-21 11:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-21 11:14 Commit: Update description of bfd_fill_in_gnu_debuglink_section Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).