From: Jan Beulich <jbeulich@suse.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] x86: Allow 16-bit register source for LAR and LSL
Date: Mon, 5 Dec 2022 12:10:58 +0100 [thread overview]
Message-ID: <88604f9d-1cc7-0c05-c92e-2561512dc96e@suse.com> (raw)
In-Reply-To: <20221203041307.34407-1-hjl.tools@gmail.com>
On 03.12.2022 05:13, H.J. Lu wrote:
> Since LAR and LSL only access 16 bits of the source operand, regardless
> of operand size, allow 16-bit register source for LAR and LSL, and always
> disassemble LAR and LSL with 16-bit source operand.
>
> gas/
>
> PR gas/29844
> * testsuite/gas/i386/i386.s: Add tests for LAR and LSL.
> * testsuite/gas/i386/x86_64.s: Likewise.
> * testsuite/gas/i386/intelbad.s: Remove "lar/lsl eax, ax".
> * testsuite/gas/i386/i386-intel.d: Updated.
> * testsuite/gas/i386/i386.d: Likewise.
> * testsuite/gas/i386/intel-intel.d: Likewise.
> * testsuite/gas/i386/intel.d: Likewise.
> * testsuite/gas/i386/intelbad.l: Likewise.
> * testsuite/gas/i386/x86_64-intel.d: Likewise.
> * testsuite/gas/i386/x86_64.d: Likewise.
>
> opcodes/
>
> PR gas/29844
> * i386-dis.c (MOD_0F02): Removed.
> (MOD_0F03): Likewise.
> (dis386_twobyte): Restore larS and lslS.
> (mod_table): Remove MOD_0F02 and MOD_0F03.
> * i386-opc.tbl: Allow 16-bit register source for LAR and LSL.
> * i386-tbl.h: Regenerated.
Please can you refrain from immediately committing patches which have
a risk of being controversial.
In the case here, given there are uses of the 16-bit register operand
form in the Linux kernel, I can accept the assembler part of the change.
The lines in i386-opc.tbl, however, need a comment then, as allowing for
16-bit registers despite a wider destination is explicitly not in line
with the SDM. (Interestingly AMD's PM is different in this regard.)
For the disassembler part you're completely undoing what I did, which is
wrong - again with reference to the SDM. If you want to accommodate for
AMD's PM, then you need to vary disassembly according to command line
options specified, with the default being in line with the SDM (I can
dig out a pretty old version of the doc, but I believe it has always
been that way, i.e. even before AMD introduced their clones).
I will revert this change unless you come forward with an adjustment
within the next couple of days.
Jan
next prev parent reply other threads:[~2022-12-05 11:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 4:13 H.J. Lu
2022-12-05 11:10 ` Jan Beulich [this message]
2022-12-05 23:20 ` H.J. Lu
2022-12-06 7:51 ` Jan Beulich
2022-12-06 16:11 ` H.J. Lu
2022-12-06 16:36 ` Jan Beulich
2022-12-06 22:32 ` H.J. Lu
2022-12-07 10:47 ` Jan Beulich
2022-12-07 23:57 ` H.J. Lu
2022-12-08 7:38 ` Jan Beulich
2022-12-09 2:11 ` H.J. Lu
2022-12-08 7:20 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88604f9d-1cc7-0c05-c92e-2561512dc96e@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).