From: Nick Clifton <nickc@redhat.com>
To: Tristan Gingold <tgingold@free.fr>,
Jan Beulich <jbeulich@suse.com>,
Tristan Gingold via Binutils <binutils@sourceware.org>
Cc: "Jose E. Marchesi" <jose.marchesi@oracle.com>
Subject: Re: [PATCH v2] pe/coff - add support for base64 encoded long section names
Date: Thu, 25 May 2023 11:24:50 +0100 [thread overview]
Message-ID: <89293134-2df0-1c6c-c0b1-a6bf3f904fc3@redhat.com> (raw)
In-Reply-To: <a878723e-8787-645f-554b-91dd1dfce250@free.fr>
Hi Tristan,
> 2023-05-24 Tristan Gingold <tgingold@free.fr>
>
> PR 30444
> * coffcode.h (coff_write_object_contents): Handle base64 encoding
> on PE. Also check for too large string table.
> * coffgen.c (extract_long_section_name): New function extracted
> from ...
> (make_a_section_from_file): ... here. Add support for base64
> long section names.
> (decode_base64): New function.
This patch looks good to me, so "approved - please apply".
I suspect that the issue of NUL padded base64 values might come up in
the future, but if it does, it will have to be with a valid test case
and then we can properly determine what to do.
Cheers
Nick
prev parent reply other threads:[~2023-05-25 10:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 19:48 Tristan Gingold
2023-05-23 6:20 ` Jan Beulich
2023-05-23 9:17 ` Jose E. Marchesi
2023-05-24 5:48 ` Tristan Gingold
2023-05-24 6:29 ` Jan Beulich
2023-05-24 17:33 ` Tristan Gingold
2023-05-25 10:24 ` Nick Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89293134-2df0-1c6c-c0b1-a6bf3f904fc3@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
--cc=jose.marchesi@oracle.com \
--cc=tgingold@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).