public inbox for
 help / color / mirror / Atom feed
From: Nick Clifton <>
To: Mark Harmstone <>,,
Subject: Re: [PATCH v2] Add pdb archive target
Date: Fri, 9 Sep 2022 11:55:14 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Mark,

> See for
> the original patch.
> Changes from original:

> * Reduced number of targets that pull this in by default

Patch approved, but with two caveats, one major, one minor:

   * Your new tests (thank you for including those) fail for targets
     which do not support the pdb archive format.  For example when
     I ran the binutils testsuite with a toolchain configured as
     --target=x86_64-pc-linux-gnu there were three new failures, all
     of which looked like this:

       binutils/.libs/ar: tmpdir/test.pdb: invalid bfd target

       FAIL: pdb archive 1

     So please could you add a test for supported targets at the start
     of the pdb.exp file ?  (See the start of dlltool.exp for an example
     of this).

   * Please could you update the comments in your C code so that they
     follow the GNU Coding Standard.  Ie:

       /* Comments start with a capital letter and end with a
          full stop followed by two spaces.  */


      reply	other threads:[~2022-09-09 10:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-09  0:14 Mark Harmstone
2022-09-09 10:55 ` Nick Clifton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).