Re: [PATCH v2] Add pdb archive target

[Nick Clifton <nickc@redhat.com>]

Hi Mark,

> See https://sourceware.org/pipermail/binutils/2022-July/122019.html for
> the original patch.
> 
> Changes from original:

> 
> * Reduced number of targets that pull this in by default

Patch approved, but with two caveats, one major, one minor:

   * Your new tests (thank you for including those) fail for targets
     which do not support the pdb archive format.  For example when
     I ran the binutils testsuite with a toolchain configured as
     --target=x86_64-pc-linux-gnu there were three new failures, all
     of which looked like this:

       binutils/.libs/ar: tmpdir/test.pdb: invalid bfd target

       FAIL: pdb archive 1

     So please could you add a test for supported targets at the start
     of the pdb.exp file ?  (See the start of dlltool.exp for an example
     of this).

   * Please could you update the comments in your C code so that they
     follow the GNU Coding Standard.  Ie:

       /* Comments start with a capital letter and end with a
          full stop followed by two spaces.  */

Cheers
   Nick