From: Jan Beulich <jbeulich@suse.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] elf: Reset alignment for each PT_LOAD segment
Date: Wed, 3 Aug 2022 10:45:11 +0200 [thread overview]
Message-ID: <8e49a184-c4f1-7156-044b-5940a2b1a204@suse.com> (raw)
In-Reply-To: <20220801231122.2503979-1-hjl.tools@gmail.com>
On 02.08.2022 01:11, H.J. Lu via Binutils wrote:
> --- a/bfd/elf.c
> +++ b/bfd/elf.c
> @@ -5439,7 +5439,7 @@ assign_file_positions_for_load_sections (bfd *abfd,
> file_ptr off; /* Octets. */
> bfd_size_type maxpagesize;
> bfd_size_type p_align;
> - bool p_align_p = false;
> + bool p_align_p;
Wouldn't it be helpful / good practice to also move the two variables
into the loop's scope (and then using initializers in favor of
assignments)? Okay preferably with that adjustment.
Jan
next prev parent reply other threads:[~2022-08-03 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 23:11 H.J. Lu
2022-08-03 8:45 ` Jan Beulich [this message]
2022-08-03 17:06 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e49a184-c4f1-7156-044b-5940a2b1a204@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).