From: Jan Beulich <jbeulich@suse.com>
To: Xiao Zeng <zengxiao@eswincomputing.com>
Cc: kito.cheng@gmail.com, palmer@dabbelt.com, nelson@rivosinc.com,
zhengyu@eswincomputing.com, binutils@sourceware.org
Subject: Re: [PATCH] RISC-V: Add support for Zimop extension
Date: Thu, 25 Apr 2024 11:51:05 +0200 [thread overview]
Message-ID: <8f26983d-7558-4260-910a-3c2182ad4a62@suse.com> (raw)
In-Reply-To: <20240425081926.86228-1-zengxiao@eswincomputing.com>
On 25.04.2024 10:19, Xiao Zeng wrote:
> This implements the Zimop (May-Be-Operations) extension, as of version 1.0.
>
> See
> <https://github.com/riscv/riscv-isa-manual/blob/main/src/zimop.adoc>
Just two cosmetic remarks (nits) on the new testcase:
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/zimop.s
> @@ -0,0 +1,44 @@
> +target:
> + # mop.r.n
> + mop.r.0 a0, a1
Would be nice if insns and comments were indented the same.
> + mop.r.1 a0, a1
> + mop.r.2 a0, a1
> + mop.r.3 a0, a1
> + mop.r.4 a0, a1
> + mop.r.5 a0, a1
> + mop.r.6 a0, a1
> + mop.r.7 a0, a1
> + mop.r.8 a0, a1
> + mop.r.9 a0, a1
> + mop.r.10 a0, a1
> + mop.r.11 a0, a1
> + mop.r.12 a0, a1
> + mop.r.13 a0, a1
> + mop.r.14 a0, a1
> + mop.r.15 a0, a1
> + mop.r.16 a0, a1
> + mop.r.17 a0, a1
> + mop.r.18 a0, a1
> + mop.r.19 a0, a1
> + mop.r.20 a0, a1
> + mop.r.21 a0, a1
> + mop.r.22 a0, a1
> + mop.r.23 a0, a1
> + mop.r.24 a0, a1
> + mop.r.25 a0, a1
> + mop.r.26 a0, a1
> + mop.r.27 a0, a1
> + mop.r.28 a0, a1
> + mop.r.29 a0, a1
> + mop.r.30 a0, a1
> + mop.r.31 a0, a1
> + # mop.rr.n
> + mop.rr.0 a0, a1, a2
> + mop.rr.1 a0, a1, a2
> + mop.rr.2 a0, a1, a2
> + mop.rr.3 a0, a1, a2
> + mop.rr.4 a0, a1, a2
> + mop.rr.5 a0, a1, a2
> + mop.rr.6 a0, a1, a2
> + mop.rr.7 a0, a1, a2
> +
> \ No newline at end of file
Please avoid such.
Jan
next prev parent reply other threads:[~2024-04-25 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 8:19 Xiao Zeng
2024-04-25 9:51 ` Jan Beulich [this message]
2024-04-25 10:12 ` Xiao Zeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f26983d-7558-4260-910a-3c2182ad4a62@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=kito.cheng@gmail.com \
--cc=nelson@rivosinc.com \
--cc=palmer@dabbelt.com \
--cc=zengxiao@eswincomputing.com \
--cc=zhengyu@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).