public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Xi Ruoyao <xry111@xry111.site>
To: mengqinggang <mengqinggang@loongson.cn>, binutils@sourceware.org
Cc: xuchenghua@loongson.cn, liuzhensong@loongson.cn,
	chenglulu@loongson.cn,  i.swmail@xen0n.name, maskray@google.com
Subject: Re: [PATCH v1 1/6] LoongArch: include: Add support for linker relaxation.
Date: Mon, 05 Dec 2022 16:24:57 +0800	[thread overview]
Message-ID: <8f5639f99caaa74a2eeee65bb4932b5c626405c1.camel@xry111.site> (raw)
In-Reply-To: <20221205080453.1352069-2-mengqinggang@loongson.cn>

On Mon, 2022-12-05 at 16:04 +0800, mengqinggang wrote:
> Add relocs and gas LARCH_opts.relax option.
> 
> include/ChangeLog:
> 
>         * elf/loongarch.h: Add relocs.
>         * opcode/loongarch.h: Add LARCH_opts.relax and macro
> LARCH_NOP.
> ---
>  include/elf/loongarch.h    | 20 ++++++++++++++++++++
>  include/opcode/loongarch.h |  3 +++
>  2 files changed, 23 insertions(+)
> 
> diff --git a/include/elf/loongarch.h b/include/elf/loongarch.h
> index a6341b46791..0ecddd17b37 100644
> --- a/include/elf/loongarch.h
> +++ b/include/elf/loongarch.h
> @@ -229,6 +229,26 @@ RELOC_NUMBER (R_LARCH_32_PCREL, 99)
>  /* RELAX.  */
>  RELOC_NUMBER (R_LARCH_RELAX, 100)
>  

Please add the description of the following new relocation types into
the psELF ABI doc first.

> +/* relax delete.  */
> +RELOC_NUMBER (R_LARCH_DELETE, 101)
> +
> +/* relax align.  */
> +RELOC_NUMBER (R_LARCH_ALIGN, 102)
> +
> +/* pcaddi.  */
> +RELOC_NUMBER (R_LARCH_PCREL20_S2, 103)
> +
> +/* cfa.  */
> +RELOC_NUMBER (R_LARCH_CFA, 104)
> +
> +/* DW_CFA_advance_loc.  */
> +RELOC_NUMBER (R_LARCH_ADD6, 105)
> +RELOC_NUMBER (R_LARCH_SUB6, 106)
> +
> +/* unsinged leb128.  */

Typo: "unsigned".

I often mistype this too.

> +RELOC_NUMBER (R_LARCH_ADD_ULEB128, 107)
> +RELOC_NUMBER (R_LARCH_SUB_ULEB128, 108)
> +

-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University

  reply	other threads:[~2022-12-05  8:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-05  8:04 [PATCH v1 0/6] LoongArch linker relaxation support mengqinggang
2022-12-05  8:04 ` [PATCH v1 1/6] LoongArch: include: Add support for linker relaxation mengqinggang
2022-12-05  8:24   ` Xi Ruoyao [this message]
2022-12-06  2:59     ` mengqinggang
2022-12-05  8:04 ` [PATCH v1 2/6] LoongArch: bfd: " mengqinggang
2022-12-05  8:04 ` [PATCH v1 3/6] LoongArch: opcodes: " mengqinggang
2022-12-05  9:43   ` Andreas Schwab
2022-12-05  8:04 ` [PATCH v1 4/6] LoongArch: binutils: " mengqinggang
2022-12-05  8:04 ` [PATCH v1 5/6] LoongArch: gas: " mengqinggang
2022-12-05  9:47   ` Andreas Schwab
2022-12-05  8:04 ` [PATCH v1 6/6] LoongArch: ld: " mengqinggang
2022-12-05  8:31   ` Xi Ruoyao
2022-12-05  8:43 ` [PATCH v1 0/6] LoongArch linker relaxation support Xi Ruoyao
2022-12-06  1:58   ` mengqinggang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f5639f99caaa74a2eeee65bb4932b5c626405c1.camel@xry111.site \
    --to=xry111@xry111.site \
    --cc=binutils@sourceware.org \
    --cc=chenglulu@loongson.cn \
    --cc=i.swmail@xen0n.name \
    --cc=liuzhensong@loongson.cn \
    --cc=maskray@google.com \
    --cc=mengqinggang@loongson.cn \
    --cc=xuchenghua@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).