public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Harmstone <mark@harmstone.com>
To: Nick Clifton <nickc@redhat.com>, binutils@sourceware.org
Subject: Re: [PATCH] ld: Set default subsystem for arm-pe to IMAGE_SUBSYSTEM_WINDOWS_GUI
Date: Mon, 23 Jan 2023 20:29:40 +0000	[thread overview]
Message-ID: <90662388-f529-91eb-cfdb-b9b55b46926f@harmstone.com> (raw)
In-Reply-To: <2e3f67f8-c401-b1ae-6ce8-1de7a8613975@redhat.com>

Thanks Nick.
> I really dislike magic numbers.  Given that coff/pe.h has been included
> at this point, why not use IMAGE_SUBSYSTEM_... instead of 2 and 9 ?
>
> A separate patch that does this for both pe.em and pep.em is pre-approved,
> should you feel motivated to do so. 

I agree - I will do.

Mark


      reply	other threads:[~2023-01-23 20:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-22 23:57 Mark Harmstone
2023-01-23 10:59 ` Nick Clifton
2023-01-23 20:29   ` Mark Harmstone [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90662388-f529-91eb-cfdb-b9b55b46926f@harmstone.com \
    --to=mark@harmstone.com \
    --cc=binutils@sourceware.org \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).