From: Nick Clifton <nickc@redhat.com>
To: Mark Harmstone <mark@harmstone.com>,
binutils@sourceware.org, amodra@gmail.com
Subject: Re: [PATCH] ld: Set default subsystem for arm-pe to IMAGE_SUBSYSTEM_WINDOWS_GUI
Date: Mon, 23 Jan 2023 10:59:46 +0000 [thread overview]
Message-ID: <2e3f67f8-c401-b1ae-6ce8-1de7a8613975@redhat.com> (raw)
In-Reply-To: <20230122235733.4160-1-mark@harmstone.com>
Hi Mark,
> This fixes the test failures introduced by 87a5cf5c, by changing the
> default subsystem for arm-pe from 9 (IMAGE_SUBSYSTEM_WINDOWS_CE_GUI) to
> 2 (IMAGE_SUBSYSTEM_WINDOWS_GUI), which matches what happens with other
> PE targets.
Approved - please apply - but ...
> -#if defined(TARGET_IS_armpe) || defined(TARGET_IS_arm_wince_pe)
> +#if defined(TARGET_IS_armpe)
> +#define PE_DEF_SECTION_ALIGNMENT 0x00001000
> +#define PE_DEF_SUBSYSTEM 2
> +#elif defined(TARGET_IS_arm_wince_pe)
> #define PE_DEF_SECTION_ALIGNMENT 0x00001000
> #define PE_DEF_SUBSYSTEM 9
> #else
I really dislike magic numbers. Given that coff/pe.h has been included
at this point, why not use IMAGE_SUBSYSTEM_... instead of 2 and 9 ?
A separate patch that does this for both pe.em and pep.em is pre-approved,
should you feel motivated to do so.
Cheers
Nick
next prev parent reply other threads:[~2023-01-23 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-22 23:57 Mark Harmstone
2023-01-23 10:59 ` Nick Clifton [this message]
2023-01-23 20:29 ` Mark Harmstone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e3f67f8-c401-b1ae-6ce8-1de7a8613975@redhat.com \
--to=nickc@redhat.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=mark@harmstone.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).