From: Jan Beulich <jbeulich@suse.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Ping: [PATCH v2 2/7] x86: improve match_template()'s diagnostics
Date: Tue, 13 Sep 2022 16:24:32 +0200 [thread overview]
Message-ID: <914d8ad7-35a3-e6f5-f636-7cf51bcd53fc@suse.com> (raw)
In-Reply-To: <0db72b1f-4026-abc8-3091-0d952044bfee@suse.com>
On 26.08.2022 12:30, Jan Beulich via Binutils wrote:
> At the example of
>
> extractps $0, %xmm0, %xmm0
> insertps $0, %xmm0, %eax
>
> (both having respectively the same mistake of using the wrong kind of
> destination register) it is easy to see that current behavior is far
> from ideal: The former results in "unsupported instruction" for 32-bit
> code simply because the 2nd template we have is a Cpu64 one. Instead we
> should aim at emitting the "best" possible error, which will typically
> be the one where we passed the largest number of checks. Generalize the
> original "specific_error" approach by making it apply to the entire
> matching loop, utilizing that line numbers increase as we pass further
> checks.
> ---
> v2: Style correction.
Like for patch 1 - since you did comment on v1, may I ask for explicit
feedback? Otherwise again: If I don't hear back by the end of next week,
I guess I'll commit this change.
Jan
next prev parent reply other threads:[~2022-09-13 14:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 10:28 [PATCH v2 0/7] x86: suffix handling changes Jan Beulich
2022-08-26 10:28 ` Jan Beulich
2022-08-26 10:30 ` [PATCH v2 1/7] x86/Intel: restrict suffix derivation Jan Beulich
2022-08-26 10:30 ` Jan Beulich
2022-09-13 14:20 ` Ping: " Jan Beulich
2022-08-26 10:30 ` [PATCH v2 2/7] x86: improve match_template()'s diagnostics Jan Beulich
2022-08-26 10:30 ` Jan Beulich
2022-09-13 14:24 ` Jan Beulich [this message]
2022-08-26 10:31 ` [PATCH v2 3/7] x86: re-work insn/suffix recognition Jan Beulich
2022-08-26 10:31 ` Jan Beulich
2022-08-26 10:32 ` [PATCH v2 4/7] x86-64: further re-work insn/suffix recognition to also cover MOVSL Jan Beulich
2022-08-26 10:32 ` Jan Beulich
2022-08-26 10:32 ` [PATCH v2 5/7] ix86: don't recognize/derive Q suffix in the common case Jan Beulich
2022-08-26 10:32 ` Jan Beulich
2022-08-26 10:33 ` [PATCH v2 6/7] x86-64: allow HLE store of accumulator to absolute 32-bit address Jan Beulich
2022-08-26 10:33 ` Jan Beulich
2022-08-26 10:33 ` [PATCH v2 7/7] x86: move bad-use-of-TLS-reloc check Jan Beulich
2022-08-26 10:33 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=914d8ad7-35a3-e6f5-f636-7cf51bcd53fc@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).