public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Luca Boccassi <bluca@debian.org>
To: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH v2] gold: add --package-metadata
Date: Thu, 04 Aug 2022 15:08:14 +0100	[thread overview]
Message-ID: <9440a3c533026a5c9ba4b29430d9fcc8c6e2d1e7.camel@debian.org> (raw)
In-Reply-To: <CAMw=ZnRM6oXqRqzMcsy_u1wij0vO6VphMZwzpNzGhNBsUKvkVg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]

On Tue, 2022-08-02 at 11:50 +0100, Luca Boccassi wrote:
> On Fri, 29 Jul 2022 at 23:29, <luca.boccassi@gmail.com> wrote:
> > 
> > From: Luca Boccassi <bluca@debian.org>
> > 
> > Following the same format as the implementation in ld:
> > 9e2bb0cb5e74aed4158f08495534922d7108f928
> > 
> > Generate a .note.package FDO package metadata ELF note, following
> > the spec: https://systemd.io/ELF_PACKAGE_METADATA/
> > 
> > If the jansson library is available at build time (and it is explicitly
> > enabled), link ld to it, and use it to validate that the input is
> > correct JSON, to avoid writing garbage to the file. The
> > configure option --enable-jansson has to be used to explicitly enable
> > it (error out when not found). This allows bootstrappers (or others who
> > are not interested) to seamlessly skip it without issues.
> > ---
> > v2: apply fixes from review
> 
> Hello Cary,
> 
> Anything else you'd like me to change here? Thanks!

CC'ing Ian on suggestion from Nick. Would be great if a maintainer
could have a look and let me know if we need more changes.

Meanwhile, Fedora has backported this patch:

https://src.fedoraproject.org/rpms/binutils/c/9ee9ffc894cc632b54d862d6213e2d8fcb8db829?branch=rawhide

-- 
Kind regards,
Luca Boccassi

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-08-04 14:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26 19:22 [PATCH] " luca.boccassi
2022-07-29 19:41 ` Cary Coutant
2022-07-29 22:30   ` Luca Boccassi
2022-07-29 22:29 ` [PATCH v2] " luca.boccassi
2022-08-02 10:50   ` Luca Boccassi
2022-08-04 14:08     ` Luca Boccassi [this message]
2022-08-05  0:41   ` Cary Coutant
2022-08-05  9:54     ` Luca Boccassi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9440a3c533026a5c9ba4b29430d9fcc8c6e2d1e7.camel@debian.org \
    --to=bluca@debian.org \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).