Re: [PATCH] SEH: Reimplement the .seh_scope directive

[Nick Clifton <nickc@redhat.com>]

Hi Julian,

> Anyone? Some reviews would help, maybe Nick or Alan?

Sorry for the delay in reviewing your patch.

Unfortunately there are a few problems:

0.  Do you have an FSF Copyright assignment for contributions
     to the GNU Binutils project.  Or are you willing to submit
     the patch under the terms of a Developer's Certificate of
     Origin ?

1. The patch does not compile:

In file included from gas/config/obj-coff.c:57:
gas/config/obj-coff-seh.c: In function 'obj_coff_seh_scope':
gas/config/obj-coff-seh.c:406:29: error: comparison between pointer and integer [-Werror]
   406 |     if (*input_line_pointer == NULL || *input_line_pointer == '\n') {
       |                             ^^

2. The code does not check to see if more than 4 arguments have been
    supplied to the .seh_scope directive.

3. There ought to be some description of the .seh_scope directive in
    the assembler's documentation.   (Although it appears that none
    of the directives are documented, which is naughty).  If your patch
    were to add some then this might encourage others to extend the
    coverage to the other directives.

4. There are various (minor) formatting issues that should be fixed
    such as the indentation, unnecessary blank lines, long lines and
    so on.  Please have a look at the GNU Coding Standards for more
    information:  https://www.gnu.org/prep/standards/

Cheers
   Nick