From: Nick Clifton <nickc@redhat.com>
To: Julian Waters <tanksherman27@gmail.com>, binutils@sourceware.org
Subject: Re: [PATCH] SEH: Reimplement the .seh_scope directive
Date: Wed, 19 Jul 2023 11:53:35 +0100 [thread overview]
Message-ID: <9519f902-a406-7b1b-76b6-20800f16af7d@redhat.com> (raw)
In-Reply-To: <CAP2b4GO=u6GywiPcgceFd9Hhi68g1bLy7rHvjORZdDG=WpQQRQ@mail.gmail.com>
Hi Julian,
> Anyone? Some reviews would help, maybe Nick or Alan?
Sorry for the delay in reviewing your patch.
Unfortunately there are a few problems:
0. Do you have an FSF Copyright assignment for contributions
to the GNU Binutils project. Or are you willing to submit
the patch under the terms of a Developer's Certificate of
Origin ?
1. The patch does not compile:
In file included from gas/config/obj-coff.c:57:
gas/config/obj-coff-seh.c: In function 'obj_coff_seh_scope':
gas/config/obj-coff-seh.c:406:29: error: comparison between pointer and integer [-Werror]
406 | if (*input_line_pointer == NULL || *input_line_pointer == '\n') {
| ^^
2. The code does not check to see if more than 4 arguments have been
supplied to the .seh_scope directive.
3. There ought to be some description of the .seh_scope directive in
the assembler's documentation. (Although it appears that none
of the directives are documented, which is naughty). If your patch
were to add some then this might encourage others to extend the
coverage to the other directives.
4. There are various (minor) formatting issues that should be fixed
such as the indentation, unnecessary blank lines, long lines and
so on. Please have a look at the GNU Coding Standards for more
information: https://www.gnu.org/prep/standards/
Cheers
Nick
next prev parent reply other threads:[~2023-07-19 10:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 2:33 Julian Waters
2023-07-19 10:53 ` Nick Clifton [this message]
2023-07-20 1:48 ` Julian Waters
2023-07-20 11:29 ` Nick Clifton
-- strict thread matches above, loose matches on Subject: below --
2023-07-14 8:01 Julian Waters
2023-07-07 9:37 Julian Waters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9519f902-a406-7b1b-76b6-20800f16af7d@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=tanksherman27@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).