From: Indu Bhagat <indu.bhagat@oracle.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: binutils@sourceware.org
Subject: Re: Missing alignment in SFrame spec
Date: Wed, 3 May 2023 10:37:50 -0700 [thread overview]
Message-ID: <971f6491-9d8e-deac-286f-58bf1c9f40e9@oracle.com> (raw)
In-Reply-To: <87ildbuv6a.fsf@oldenburg.str.redhat.com>
On 5/1/23 11:03 PM, Florian Weimer via Binutils wrote:
> * Indu Bhagat:
>
>> On 4/28/23 01:08, Florian Weimer wrote:
>>> The SFrame specification does not say anything explict about alignment.
>>> It uses ATTRIBUTE_PACKED, which strongly suggests alignment 1, but
>>> looking at the structures themselves, I think what you actually want is
>>> 4-byte alignment.
>>> Thanks,
>>> Florian
>>>
>>
>> Hi Florian,
>>
>> SFrame stack trace format is an unaligned on-disk format. IIUC, you
>> suggest 4 byte alignment for all structs in SFrame format?
>>
>> Yes, current SFrame FDE and SFrame FRE are 1-byte aligned.
>>
>> I had reasoned about unaligned accesses previously when a bug showed up.
>
> Well, GAS seems to generate 8-byte-aligned .sframe sections (at least in
> the 2.40-7.fc39 Fedora package). So all this is a bit inconsistent.
>
I will work on making the spec clear about alignment expectations for
the .sframe section and the various definitions in the format.
> Thanks,
> Florian
>
prev parent reply other threads:[~2023-05-03 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 8:08 Florian Weimer
2023-05-02 0:24 ` Indu Bhagat
2023-05-02 6:03 ` Florian Weimer
2023-05-03 17:37 ` Indu Bhagat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=971f6491-9d8e-deac-286f-58bf1c9f40e9@oracle.com \
--to=indu.bhagat@oracle.com \
--cc=binutils@sourceware.org \
--cc=fweimer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).