Re: [PATCH 0/5] Add Xtensa ESP chips support

[Alexey Lapshin <alexey.lapshin@espressif.com>]

Hi Max,

Thank you for reaching out. Yes, patch 4/5 is too big and should be
split into at least 6 parts to upload here.

I uploaded changes to the github:
https://github.com/espressif/binutils-gdb/commits/feature/binutils-2_39-port-esp-chips
Regards,
Alexey


On Tue, 2022-10-25 at 12:13 -0700, Max Filippov wrote:
> [External: This email originated outside Espressif]
> 
> Hi Alexey,
> 
> On Sat, Oct 22, 2022 at 5:51 AM Alexey Lapshin via Binutils
> <binutils@sourceware.org> wrote:
> > 
> > Since ESP chips are getting more and more popular for developers I
> > would like to suggest these patches to consider to include Xtensa
> > ESP
> > chips support for binutils and gdb.
> > 
> > The chips support was done in a not common binutils way. There are
> > a
> > few reasons for that:
> > As I know, the Xtensa specific code for binutils and gdb is
> > generated
> > with tools from Tensilica Inc.
> > To build binutils and gdb with other chip presets we need to
> > override
> > some related files (https://github.com/espressif/xtensa-overlays).
> > To make it easy to integrate new chips I did refactor the code a
> > bit to
> > make a possibility to just copy and paste Tensilica-generated files
> > and
> > modify a few lines in a code to make it supported in binutils and
> > gdb.
> > 
> > Please consider these changes to merge, I believe this could be a
> > pretty improvement to extend supported CPUs without using third-
> > party
> > sources patches.
> > 
> > Alexey Lapshin (5):
> >   bfd: xtensa: move common code from ld and gas
> >   gas: xtensa: add endianness, loops, booleans options
> >   ld: xtensa: use default LD command line options to specify
> > endianness
> >   gas: xtensa: add esp32, esp32s2, esp32s3 isa-modules options
> >   gdb: xtensa: add support for esp32, esp32s2, esp32s3 isa-modules
> 
> I'd like to review this series but it has two technical issues:
> - the patches are not in plain text format and so git am is unable to
> apply them
> - the 4th patch of the series didn't make it through the list, I
> guess
> it's too big
> 
> I guess the easiest way for me to review this series is if you could
> point
> me to a public git repository with these patches. Alternatively you
> could
> use git send-email to send the patches, split patch 4 into pieces
> (e.g.
> one core per patch) and add me to the cc: list.
> 
> --
> Thanks.
> -- Max