From: Max Filippov <jcmvbkbc@gmail.com>
To: Alexey Lapshin <alexey.lapshin@espressif.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>,
Anton Maklakov <anton.maklakov@espressif.com>,
Alexey Gerenkov <alexey.gerenkov@espressif.com>,
Ivan Grokhotkov <ivan@espressif.com>
Subject: Re: [PATCH 0/5] Add Xtensa ESP chips support
Date: Tue, 25 Oct 2022 12:13:37 -0700 [thread overview]
Message-ID: <CAMo8Bf+syYg0_eXJ5JL_oGLC++bKAT7gTir4VYRSYFkyEq3tsw@mail.gmail.com> (raw)
In-Reply-To: <94fd668465b77e94f3c000982c694e7da8f828f1.camel@espressif.com>
Hi Alexey,
On Sat, Oct 22, 2022 at 5:51 AM Alexey Lapshin via Binutils
<binutils@sourceware.org> wrote:
>
> Since ESP chips are getting more and more popular for developers I
> would like to suggest these patches to consider to include Xtensa ESP
> chips support for binutils and gdb.
>
> The chips support was done in a not common binutils way. There are a
> few reasons for that:
> As I know, the Xtensa specific code for binutils and gdb is generated
> with tools from Tensilica Inc.
> To build binutils and gdb with other chip presets we need to override
> some related files (https://github.com/espressif/xtensa-overlays).
> To make it easy to integrate new chips I did refactor the code a bit to
> make a possibility to just copy and paste Tensilica-generated files and
> modify a few lines in a code to make it supported in binutils and gdb.
>
> Please consider these changes to merge, I believe this could be a
> pretty improvement to extend supported CPUs without using third-party
> sources patches.
>
> Alexey Lapshin (5):
> bfd: xtensa: move common code from ld and gas
> gas: xtensa: add endianness, loops, booleans options
> ld: xtensa: use default LD command line options to specify endianness
> gas: xtensa: add esp32, esp32s2, esp32s3 isa-modules options
> gdb: xtensa: add support for esp32, esp32s2, esp32s3 isa-modules
I'd like to review this series but it has two technical issues:
- the patches are not in plain text format and so git am is unable to apply them
- the 4th patch of the series didn't make it through the list, I guess
it's too big
I guess the easiest way for me to review this series is if you could point
me to a public git repository with these patches. Alternatively you could
use git send-email to send the patches, split patch 4 into pieces (e.g.
one core per patch) and add me to the cc: list.
--
Thanks.
-- Max
next prev parent reply other threads:[~2022-10-25 19:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 12:51 Alexey Lapshin
2022-10-22 12:53 ` [PATCH 1/5] bfd: xtensa: move common code from ld and gas Alexey Lapshin
2022-10-22 12:55 ` [PATCH 2/5] gas: xtensa: add endianness, loops, booleans options Alexey Lapshin
2022-10-22 12:56 ` [PATCH 3/5] ld: xtensa: use default LD command line options for endianness Alexey Lapshin
2022-10-22 13:54 ` [PATCH 4/5] gas: xtensa: add esp32, esp32s2, esp32s3 isa-modules options Alexey Lapshin
2022-10-22 13:56 ` [PATCH 5/5] gdb: xtensa: add support for esp32, esp32s2, esp32s3 isa-modules Alexey Lapshin
2022-10-25 19:13 ` Max Filippov [this message]
2022-10-25 20:17 ` [PATCH 0/5] Add Xtensa ESP chips support Alexey Lapshin
2022-10-27 15:39 ` Max Filippov
2022-10-27 19:39 ` Alexey Lapshin
2022-10-28 15:48 ` Max Filippov
2022-10-28 16:05 ` Max Filippov
2022-10-31 6:38 ` Alexey Lapshin
2022-10-31 16:10 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMo8Bf+syYg0_eXJ5JL_oGLC++bKAT7gTir4VYRSYFkyEq3tsw@mail.gmail.com \
--to=jcmvbkbc@gmail.com \
--cc=alexey.gerenkov@espressif.com \
--cc=alexey.lapshin@espressif.com \
--cc=anton.maklakov@espressif.com \
--cc=binutils@sourceware.org \
--cc=ivan@espressif.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).