From: Nick Clifton <nickc@redhat.com>
To: Tom de Vries <tdevries@suse.de>, binutils@sourceware.org
Subject: Re: [PATCH 2/2] [readelf] Handle .gdb_index section version 9
Date: Mon, 9 Oct 2023 14:49:09 +0100 [thread overview]
Message-ID: <9d938236-cf37-a3a2-a530-1905ff8d38a9@redhat.com> (raw)
In-Reply-To: <20231006174942.27361-3-tdevries@suse.de>
Hi Tom,
> Add the abilitity to print a v9 .gdb_index section.
>
> The v9 section contains an extra table, which is printed as follows:
The patch looks good to me, except for one small issue:
> + if (version > 9)
> + {
> + printf (_("\nShortcut table:\n"));
> +
[....]
Shouldn't that test be for "version >= 9" ?
Patch approved, possibly with a small change if the suggestion above is correct.
Cheers
Nick
prev parent reply other threads:[~2023-10-09 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 17:49 [PATCH 0/2] Add name_of_main and language_of_main to the DWARF index Tom de Vries
2023-10-06 17:49 ` [PATCH 1/2] [gdb/symtab] " Tom de Vries
2023-10-06 17:49 ` [PATCH 2/2] [readelf] Handle .gdb_index section version 9 Tom de Vries
2023-10-09 13:49 ` Nick Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d938236-cf37-a3a2-a530-1905ff8d38a9@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).