public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@gmail.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: Kito Cheng <kito.cheng@sifive.com>, Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] RISC-V: Maintain a string to hold the canonical order
Date: Mon, 21 Feb 2022 23:12:43 +0800	[thread overview]
Message-ID: <CA+yXCZBaCtsjZDGZRV1a-uE4RX0gj76f0fTt8w3JZw5VdqTXJA@mail.gmail.com> (raw)
In-Reply-To: <d179f232-6c30-63da-7a47-1f7ec5914cf1@irq.a4lg.com>

> Just "*ext" or "*ext != '\0'"? comparing a const char (not pointer) with
> NULL looks a bit odd.

Thanks for catching that, that's functional equivalent, but definitely
wrong semantic.

      reply	other threads:[~2022-02-21 15:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21 14:47 Kito Cheng
2022-02-21 14:50 ` Tsukasa OI
2022-02-21 15:02 ` Tsukasa OI
2022-02-21 15:12   ` Kito Cheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+yXCZBaCtsjZDGZRV1a-uE4RX0gj76f0fTt8w3JZw5VdqTXJA@mail.gmail.com \
    --to=kito.cheng@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=kito.cheng@sifive.com \
    --cc=research_trasio@irq.a4lg.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).