From: Kito Cheng <kito.cheng@gmail.com>
To: Nelson Chu <nelson@rivosinc.com>
Cc: Mary Bennett <mary.bennett@embecosm.com>,
binutils@sourceware.org, Jim Wilson <jim.wilson.gcc@gmail.com>,
Jeff Law <jlaw@ventanamicro.com>,
Kito Cheng <kito.cheng@sifive.com>,
Palmer Dabbelt <palmer@rivosinc.com>,
Andrew Waterman <andrew@sifive.com>
Subject: Re: [PATCH 0/2] RISC-V: Support CORE-V XCVMAC and XCVALU extensions
Date: Thu, 7 Sep 2023 14:57:07 +0800 [thread overview]
Message-ID: <CA+yXCZCLJhuKpw1msmcH787E+-=DPBi_TV=z_qTPdDood+kjjA@mail.gmail.com> (raw)
In-Reply-To: <CAPpQWtDaY6ZaSpEj-PKzKgBXn0fxDkBAeZybKTpPfxd_sKJg=g@mail.gmail.com>
I am open mind to accept Core-v support for GNU toolchain, and I think
binutils should support first :P
On Thu, Sep 7, 2023 at 12:50 PM Nelson Chu <nelson@rivosinc.com> wrote:
>
> Hi Mary,
>
> Thanks for the contribution, the vendor core-v extensions in binutils look
> good to me :-)
>
> Hi Jeff, Kito, Palmer and Andrew,
>
> I am not sure if we are likely to accept the vendor core-v extension only
> in binutils first? Or if we prefer to accept it with the whole toolchain
> support, including gcc and qemu. Need your help, thanks!
>
> If I forgot to cc anyone who may be related, please feel free to add them
> in the discussion!
>
> Nelson
>
> On Tue, Sep 5, 2023 at 10:53 PM Mary Bennett <mary.bennett@embecosm.com>
> wrote:
>
> > This patch series presents the comprehensive implementation of the MAC and
> > ALU
> > extension for CORE-V.
> >
> > Tested with riscv-gnu-toolchain on binutils, ld, gas and gcc testsuites to
> > ensure its correctness and compatibility with the existing codebase.
> > However, your input, reviews, and suggestions are invaluable in making this
> > extension even more robust.
> >
> > The CORE-V instructions are described in the specification [1] and work
> > can be
> > found in the OpenHW group's Github repository [2].
> >
> > [1]
> > docs.openhwgroup.org/projects/cv32e40p-user-manual/en/latest/instruction_set_extensions.html
> >
> > [2] github.com/openhwgroup/corev-binutils-gdb
> >
> > Contributors:
> > Mary Bennett <mary.bennett@embecosm.com>
> > Nandni Jamnadas <nandni.jamnadas@embecosm.com>
> > Pietra Ferreira <pietra.ferreira@embecosm.com>
> > Charlie Keaney
> > Jessica Mills
> > Craig Blackmore <craig.blackmore@embecosm.com>
> > Simon Cook <simon.cook@embecosm.com>
> > Jeremy Bennett <jeremy.bennett@embecosm.com>
> >
> > RISC-V: Add support for XCValu extension in CV32E40P
> > RISC-V: Add support for XCVmac extension in CV32E40P
> >
> > bfd/elfxx-riscv.c | 11 ++
> > gas/config/tc-riscv.c | 60 +++++++
> > gas/doc/c-riscv.texi | 10 ++
> > gas/testsuite/gas/riscv/cv-alu-boundaries.d | 3 +
> > gas/testsuite/gas/riscv/cv-alu-boundaries.l | 14 ++
> > gas/testsuite/gas/riscv/cv-alu-boundaries.s | 27 +++
> > gas/testsuite/gas/riscv/cv-alu-fail-march.d | 3 +
> > gas/testsuite/gas/riscv/cv-alu-fail-march.l | 32 ++++
> > gas/testsuite/gas/riscv/cv-alu-fail-march.s | 33 ++++
> > .../gas/riscv/cv-alu-fail-operand-01.d | 3 +
> > .../gas/riscv/cv-alu-fail-operand-01.l | 32 ++++
> > .../gas/riscv/cv-alu-fail-operand-01.s | 33 ++++
> > .../gas/riscv/cv-alu-fail-operand-02.d | 3 +
> > .../gas/riscv/cv-alu-fail-operand-02.l | 32 ++++
> > .../gas/riscv/cv-alu-fail-operand-02.s | 33 ++++
> > .../gas/riscv/cv-alu-fail-operand-03.d | 3 +
> > .../gas/riscv/cv-alu-fail-operand-03.l | 25 +++
> > .../gas/riscv/cv-alu-fail-operand-03.s | 26 +++
> > .../gas/riscv/cv-alu-fail-operand-04.d | 3 +
> > .../gas/riscv/cv-alu-fail-operand-04.l | 3 +
> > .../gas/riscv/cv-alu-fail-operand-04.s | 4 +
> > .../gas/riscv/cv-alu-fail-operand-05.d | 3 +
> > .../gas/riscv/cv-alu-fail-operand-05.l | 9 +
> > .../gas/riscv/cv-alu-fail-operand-05.s | 10 ++
> > .../gas/riscv/cv-alu-fail-operand-06.d | 3 +
> > .../gas/riscv/cv-alu-fail-operand-06.l | 9 +
> > .../gas/riscv/cv-alu-fail-operand-06.s | 10 ++
> > .../gas/riscv/cv-alu-fail-operand-07.d | 3 +
> > .../gas/riscv/cv-alu-fail-operand-07.l | 33 ++++
> > .../gas/riscv/cv-alu-fail-operand-07.s | 34 ++++
> > gas/testsuite/gas/riscv/cv-alu-insns.d | 102 ++++++++++++
> > gas/testsuite/gas/riscv/cv-alu-insns.s | 124 ++++++++++++++
> > gas/testsuite/gas/riscv/cv-mac-fail-march.d | 3 +
> > gas/testsuite/gas/riscv/cv-mac-fail-march.l | 23 +++
> > gas/testsuite/gas/riscv/cv-mac-fail-march.s | 24 +++
> > gas/testsuite/gas/riscv/cv-mac-fail-operand.d | 3 +
> > gas/testsuite/gas/riscv/cv-mac-fail-operand.l | 147 +++++++++++++++++
> > gas/testsuite/gas/riscv/cv-mac-fail-operand.s | 156 ++++++++++++++++++
> > gas/testsuite/gas/riscv/cv-mac-insns.d | 87 ++++++++++
> > gas/testsuite/gas/riscv/cv-mac-insns.s | 81 +++++++++
> > include/opcode/riscv-opc.h | 56 +++++++
> > include/opcode/riscv.h | 12 ++
> > opcodes/riscv-dis.c | 20 +++
> > opcodes/riscv-opc.c | 61 +++++++
> > 44 files changed, 1406 insertions(+)
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-boundaries.d
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-boundaries.l
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-boundaries.s
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-march.d
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-march.l
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-march.s
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-01.d
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-01.l
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-01.s
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-02.d
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-02.l
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-02.s
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-03.d
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-03.l
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-03.s
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-04.d
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-04.l
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-04.s
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-05.d
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-05.l
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-05.s
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-06.d
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-06.l
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-06.s
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-07.d
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-07.l
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-fail-operand-07.s
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-insns.d
> > create mode 100644 gas/testsuite/gas/riscv/cv-alu-insns.s
> > create mode 100644 gas/testsuite/gas/riscv/cv-mac-fail-march.d
> > create mode 100644 gas/testsuite/gas/riscv/cv-mac-fail-march.l
> > create mode 100644 gas/testsuite/gas/riscv/cv-mac-fail-march.s
> > create mode 100644 gas/testsuite/gas/riscv/cv-mac-fail-operand.d
> > create mode 100644 gas/testsuite/gas/riscv/cv-mac-fail-operand.l
> > create mode 100644 gas/testsuite/gas/riscv/cv-mac-fail-operand.s
> > create mode 100644 gas/testsuite/gas/riscv/cv-mac-insns.d
> > create mode 100644 gas/testsuite/gas/riscv/cv-mac-insns.s
> >
> > --
> > 2.34.1
> >
> >
next prev parent reply other threads:[~2023-09-07 6:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 14:52 Mary Bennett
2023-09-05 14:52 ` [PATCH 1/2] RISC-V: Add support for XCVmac extension in CV32E40P Mary Bennett
2023-09-07 4:35 ` Nelson Chu
2023-09-05 14:53 ` [PATCH 2/2] RISC-V: Add support for XCValu " Mary Bennett
2023-09-07 4:37 ` Nelson Chu
2023-09-07 4:49 ` [PATCH 0/2] RISC-V: Support CORE-V XCVMAC and XCVALU extensions Nelson Chu
2023-09-07 6:57 ` Kito Cheng [this message]
2023-09-07 10:11 ` Tsukasa OI
2023-09-12 14:24 ` [PATCH v2 " Mary Bennett
2023-09-12 14:24 ` [PATCH v2 1/2] RISC-V: Add support for XCVmac extension in CV32E40P Mary Bennett
2023-09-12 14:24 ` [PATCH v2 2/2] RISC-V: Add support for XCValu " Mary Bennett
2023-10-02 2:02 ` [PATCH v3 0/2] RISC-V: Support CORE-V XCVMAC and XCVALU extensions Mary Bennett
2023-10-02 2:02 ` [PATCH v3 1/2] RISC-V: Add support for XCVmac extension in CV32E40P Mary Bennett
2023-10-02 2:02 ` [PATCH v3 2/2] RISC-V: Add support for XCValu " Mary Bennett
2023-11-06 17:27 ` [PATCH v3 0/2] RISC-V: Support CORE-V XCVMAC and XCVALU extensions Mary Bennett
2023-11-07 4:12 ` Nelson Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+yXCZCLJhuKpw1msmcH787E+-=DPBi_TV=z_qTPdDood+kjjA@mail.gmail.com' \
--to=kito.cheng@gmail.com \
--cc=andrew@sifive.com \
--cc=binutils@sourceware.org \
--cc=jim.wilson.gcc@gmail.com \
--cc=jlaw@ventanamicro.com \
--cc=kito.cheng@sifive.com \
--cc=mary.bennett@embecosm.com \
--cc=nelson@rivosinc.com \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).