[COMMITTED PATCH] bfd/doc: Fix racy build failure from missing mkdir

[COMMITTED PATCH] bfd/doc: Fix racy build failure from missing mkdir

[Roland McGrath]

I'm not sure how new this is, but I've started seeing a build failure
from bfd/doc not existing in the build directory.
Committed as obvious enough.

Thanks,
Roland

bfd/
2022-01-24  Roland McGrath  <mcgrathr@google.com>

        * doc/local.mk (%D%/bfdver.texi): Add mkdir command.

diff --git a/bfd/doc/local.mk b/bfd/doc/local.mk
index 18a2af1b01d..6a9cceb727a 100644
--- a/bfd/doc/local.mk
+++ b/bfd/doc/local.mk
@@ -127,6 +127,7 @@ REGEN_TEXI = \

 %D%/bfdver.texi: $(srcdir)/Makefile.in
        $(AM_V_GEN)\
+       $(MKDIR_P) $(@D); \
        echo "@set VERSION $(VERSION)" > $@; \
        if test -n "$(PKGVERSION)"; then \
          echo "@set VERSION_PACKAGE $(PKGVERSION)" >> $@; \

Re: [COMMITTED PATCH] bfd/doc: Fix racy build failure from missing mkdir

[H.J. Lu]

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]

On Mon, Jan 24, 2022 at 12:45 PM Roland McGrath via Binutils
<binutils@sourceware.org> wrote:
>
> I'm not sure how new this is, but I've started seeing a build failure
> from bfd/doc not existing in the build directory.
> Committed as obvious enough.
>
> Thanks,
> Roland
>
> bfd/
> 2022-01-24  Roland McGrath  <mcgrathr@google.com>
>
>         * doc/local.mk (%D%/bfdver.texi): Add mkdir command.
>
> diff --git a/bfd/doc/local.mk b/bfd/doc/local.mk
> index 18a2af1b01d..6a9cceb727a 100644
> --- a/bfd/doc/local.mk
> +++ b/bfd/doc/local.mk
> @@ -127,6 +127,7 @@ REGEN_TEXI = \
>
>  %D%/bfdver.texi: $(srcdir)/Makefile.in
>         $(AM_V_GEN)\
> +       $(MKDIR_P) $(@D); \
>         echo "@set VERSION $(VERSION)" > $@; \
>         if test -n "$(PKGVERSION)"; then \
>           echo "@set VERSION_PACKAGE $(PKGVERSION)" >> $@; \

I am checking in this.

-- 
H.J.

[-- Attachment #2: 0001-bfd-Regenerate-Makefile.in.patch --]
[-- Type: text/x-patch, Size: 737 bytes --]

From 042a82e5ee2613909e700a6f4b11ec72a74d2ebd Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Tue, 25 Jan 2022 08:54:36 -0800
Subject: [PATCH] bfd: Regenerate Makefile.in

	* Makefile.in: Regenerate.
---
 bfd/Makefile.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bfd/Makefile.in b/bfd/Makefile.in
index b06c0c98e9b..5a9b32cd25c 100644
--- a/bfd/Makefile.in
+++ b/bfd/Makefile.in
@@ -2514,6 +2514,7 @@ doc/bfdt.stamp: $(srcdir)/bfd.c $(srcdir)/doc/doc.str $(MKDOC) doc/$(am__dirstam
 
 doc/bfdver.texi: $(srcdir)/Makefile.in
 	$(AM_V_GEN)\
+	$(MKDIR_P) $(@D); \
 	echo "@set VERSION $(VERSION)" > $@; \
 	if test -n "$(PKGVERSION)"; then \
 	  echo "@set VERSION_PACKAGE $(PKGVERSION)" >> $@; \
-- 
2.34.1

Re: [COMMITTED PATCH] bfd/doc: Fix racy build failure from missing mkdir

[Roland McGrath]

Oops!  Thanks. I lost track of what all was generated from what.


On Tue, Jan 25, 2022 at 8:56 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Mon, Jan 24, 2022 at 12:45 PM Roland McGrath via Binutils
> <binutils@sourceware.org> wrote:
> >
> > I'm not sure how new this is, but I've started seeing a build failure
> > from bfd/doc not existing in the build directory.
> > Committed as obvious enough.
> >
> > Thanks,
> > Roland
> >
> > bfd/
> > 2022-01-24  Roland McGrath  <mcgrathr@google.com>
> >
> >         * doc/local.mk (%D%/bfdver.texi): Add mkdir command.
> >
> > diff --git a/bfd/doc/local.mk b/bfd/doc/local.mk
> > index 18a2af1b01d..6a9cceb727a 100644
> > --- a/bfd/doc/local.mk
> > +++ b/bfd/doc/local.mk
> > @@ -127,6 +127,7 @@ REGEN_TEXI = \
> >
> >  %D%/bfdver.texi: $(srcdir)/Makefile.in
> >         $(AM_V_GEN)\
> > +       $(MKDIR_P) $(@D); \
> >         echo "@set VERSION $(VERSION)" > $@; \
> >         if test -n "$(PKGVERSION)"; then \
> >           echo "@set VERSION_PACKAGE $(PKGVERSION)" >> $@; \
>
> I am checking in this.
>
> --
> H.J.