From: Oleg Tolmatcev <oleg.tolmatcev@gmail.com>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] optimize handle_COMDAT
Date: Thu, 4 May 2023 19:33:25 +0200 [thread overview]
Message-ID: <CACcXsZgVavFBcqDHmETSTnvAa302+G-dBEXSo0U88QR15mCnCw@mail.gmail.com> (raw)
In-Reply-To: <ZFMwbdNBCSYV1xvJ@squeak.grove.modra.org>
Am Do., 4. Mai 2023 um 06:11 Uhr schrieb Alan Modra <amodra@gmail.com>:
>
> On Sat, Apr 29, 2023 at 02:39:00PM +0200, Oleg Tolmatcev via Binutils wrote:
> > Thanks for the review. Here is a new version.
>
> The patch you posted to the list is truncated, and the patch you sent
> me privately was somehow corrupted, with tabs being replaced with 4
> spaces and the single space lines in the patch being replaced with an
> empty line. Please fix your email client and/or editor. I applied it
> by hand, and found
>
> FAIL: Build pe-x86-64-1
> FAIL: Build pe-x86-64-2
> FAIL: Build pe-x86-64-3
> FAIL: Build pe-x86-64-6
>
> when running the testsuite on an x86_64-linux build. This is not
> acceptable. I also see you have ripped out more than just a little
> sanity checking and other code you didn't understand. Do you expect
> Nick or I to fix your patches for you?
Thanks for the review Alan. No I do not. It is my first time trying to
contribute, which is why I made mistakes. I am sorry.
prev parent reply other threads:[~2023-05-04 17:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 16:48 Oleg Tolmatcev
2023-04-26 5:59 ` Alan Modra
2023-04-29 12:39 ` Oleg Tolmatcev
2023-05-04 4:11 ` Alan Modra
2023-05-04 17:33 ` Oleg Tolmatcev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACcXsZgVavFBcqDHmETSTnvAa302+G-dBEXSo0U88QR15mCnCw@mail.gmail.com \
--to=oleg.tolmatcev@gmail.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).