From: "Clément Chigot" <chigot@adacore.com>
To: binutils@sourceware.org
Cc: amodra@gmail.com
Subject: Re: [PATCH] ld/testsuite: handle Windows drive letter in persistent section
Date: Tue, 21 Feb 2023 10:14:03 +0100 [thread overview]
Message-ID: <CAJ307Ej_NduP8Hf475kwofP4v8JXc2FEDw1962B-ahngwLq3-A@mail.gmail.com> (raw)
In-Reply-To: <20230221090331.559683-1-chigot@adacore.com>
Hi Alan,
Here is another test having an issue with paths starting with C:, that
I've missed in first place.
However, it had made me wonder if no other tests would have this issue
(even if I'm not launching because of whatever reasons).
For ld/testsuite, noinit sections and this one seems the only ones
having this pattern "[^:] :".
However, in gas/testsuite, there are plenty of them, more than 16k lines.
But, investigating deeper, I don't have issues with them on my setup
because gas errors are based on the targeted files and I'm passing
them with a Linux path-style.
| $ gas /a/random/path.s
| /a/random/path.s: error ...
With ld, the error is printing the ld executable path which in my case
is a Windows-style path.
| $ ld /a/random/path.o
| C:/path/to/ld.exe: error ...
All that to say, as is, I don't have to modify any testcase in
gas/testsuite. But to be coherent, I guess it would be better to do
it.
But as it represents huge modifications, I would like to have your
opinion on that first.
Thanks, Clément
next prev parent reply other threads:[~2023-02-21 9:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 9:03 Clément Chigot
2023-02-21 9:14 ` Clément Chigot [this message]
2023-02-21 9:25 ` Jan Beulich
2023-02-21 16:16 ` Clément Chigot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ307Ej_NduP8Hf475kwofP4v8JXc2FEDw1962B-ahngwLq3-A@mail.gmail.com \
--to=chigot@adacore.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).