From: Jan Beulich <jbeulich@suse.com>
To: "Clément Chigot" <chigot@adacore.com>
Cc: amodra@gmail.com, binutils@sourceware.org
Subject: Re: [PATCH] ld/testsuite: handle Windows drive letter in persistent section
Date: Tue, 21 Feb 2023 10:25:03 +0100 [thread overview]
Message-ID: <824ba77c-a471-6bbb-b77e-fd77eb2dd5a8@suse.com> (raw)
In-Reply-To: <20230221090331.559683-1-chigot@adacore.com>
On 21.02.2023 10:03, Clément Chigot via Binutils wrote:
> --- a/ld/testsuite/ld-elf/persistent-sections-2.l
> +++ b/ld/testsuite/ld-elf/persistent-sections-2.l
> @@ -1,5 +1,5 @@
> #...
> -[^:]*: warning: orphan section `.persistent.var_persistent' from \S+ being placed in section `.persistent.var_persistent'
> +(|.:)[^:]*: warning: orphan section `.persistent.var_persistent' from \S+ being placed in section `.persistent.var_persistent'
> #...
> -[^:]*: warning: orphan section `.gnu.linkonce.p.var_persistent2' from \S+ being placed in section `.gnu.linkonce.p.var_persistent2'
> +(|.:)[^:]*: warning: orphan section `.gnu.linkonce.p.var_persistent2' from \S+ being placed in section `.gnu.linkonce.p.var_persistent2'
Personally I find "(|.:)" slightly less intuitive than "(.:)?", so could
I maybe talk you into using the alternative form?
However, seeing your further reply (mainly targeted at Alan) I also
wonder whether the issue can't be addressed in a more general manner, by
pruning drive letters from diagnostics before actually doing any regexp
matching. Such pruning could then also be limited to actually running on
Windows, whereas changing expectations in test cases would affect all
targets.
Jan
next prev parent reply other threads:[~2023-02-21 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 9:03 Clément Chigot
2023-02-21 9:14 ` Clément Chigot
2023-02-21 9:25 ` Jan Beulich [this message]
2023-02-21 16:16 ` Clément Chigot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=824ba77c-a471-6bbb-b77e-fd77eb2dd5a8@suse.com \
--to=jbeulich@suse.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=chigot@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).