[PATCH] Support --no-rosegment.

[PATCH] Support --no-rosegment.

[Fangrui Song via binutils]

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: gold.patch --]
[-- Type: text/x-diff, Size: 1286 bytes --]

From 38a33693f406d1cce6877bf6baa67c368e243485 Mon Sep 17 00:00:00 2001
From: Fangrui Song <maskray@google.com>
Date: Thu, 19 Dec 2019 17:40:17 -0800
Subject: [PATCH] Support --no-rosegment.
To: binutils@sourceware.org

gold/
    * options.h (General_options): Add --no-rosegment option.
---
 gold/ChangeLog | 4 ++++
 gold/options.h | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gold/ChangeLog b/gold/ChangeLog
index 3dc2ce81b7..60ce5d7719 100644
--- a/gold/ChangeLog
+++ b/gold/ChangeLog
@@ -1,3 +1,7 @@
+2019-12-19  Fangrui Song  <maskray@google.com>
+
+	* options.h (General_options): Add --no-rosegment option.
+
 2019-11-26  Martin Liska  <mliska@suse.cz>
 
 	* layout.cc (Layout::special_ordering_of_input_section):
diff --git a/gold/options.h b/gold/options.h
index f7c127953c..ab7f2d946f 100644
--- a/gold/options.h
+++ b/gold/options.h
@@ -1182,7 +1182,7 @@ class General_options
 
   DEFINE_bool(rosegment, options::TWO_DASHES, '\0', false,
 	      N_("Put read-only non-executable sections in their own segment"),
-	      NULL);
+	      N_("Do not put read-only non-executable sections in their own segment"));
 
   DEFINE_uint64(rosegment_gap, options::TWO_DASHES, '\0', -1U,
 		N_("Set offset between executable and read-only segments"),
-- 
2.24.0

Re: [PATCH] Support --no-rosegment.

[Fāng-ruì Sòng via binutils]

On Thu, Dec 19, 2019 at 5:53 PM Fangrui Song <maskray@google.com> wrote:

Ping:)

Re: [PATCH] Support --no-rosegment.

[Nick Clifton]

Hi Fāng-ruì,

> Ping:)

My apologies - I cannot find the original email.   Please
could you provide me with a link to it ?

Cheers
  Nick

Re: [PATCH] Support --no-rosegment.

[Fāng-ruì Sòng via binutils]

On Mon, Mar 2, 2020 at 5:00 AM Nick Clifton <nickc@redhat.com> wrote:

> Hi Fāng-ruì,
>
> > Ping:)
>
> My apologies - I cannot find the original email.   Please
> could you provide me with a link to it ?
>
> Cheers
>   Nick
>
Hi Nick,

The patch is in https://sourceware.org/ml/binutils/2019-12/msg00296.html

Thanks!
Fangrui


-- 
宋方睿

Re: [PATCH] Support --no-rosegment.

[Nick Clifton]

Hi Fāng-ruì,

> The patch is in https://sourceware.org/ml/binutils/2019-12/msg00296.html

Ah - it is a patch for gold.  Sorry, but I cannot approve such patches.
You will need to ping Ian or Cary for this.

Cheers
  Nick

Re: [PATCH] Support --no-rosegment.

[Cary Coutant]

> Ah - it is a patch for gold.  Sorry, but I cannot approve such patches.
> You will need to ping Ian or Cary for this.

gold/
    * options.h (General_options): Add --no-rosegment option.

This is OK.

(Sorry for the delay. I'm still working on getting back into the
regular routine.)

-cary

Re: [PATCH] Support --no-rosegment.

[Fangrui Song]

On Tue, Mar 17, 2020, 15:01 Cary Coutant via Binutils <
binutils@sourceware.org> wrote:

> > Ah - it is a patch for gold.  Sorry, but I cannot approve such patches.
> > You will need to ping Ian or Cary for this.
>
> gold/
>     * options.h (General_options): Add --no-rosegment option.
>
> This is OK.
>
> (Sorry for the delay. I'm still working on getting back into the
> regular routine.)
>
> -cary
>

Can you commit it for me:)

I don't have commit permission.

>

Re: [PATCH] Support --no-rosegment.

[Cary Coutant]

Will do.

-cary

On Tue, Mar 17, 2020 at 4:23 PM Fangrui Song <i@maskray.me> wrote:
>
>
>
> On Tue, Mar 17, 2020, 15:01 Cary Coutant via Binutils <binutils@sourceware.org> wrote:
>>
>> > Ah - it is a patch for gold.  Sorry, but I cannot approve such patches.
>> > You will need to ping Ian or Cary for this.
>>
>> gold/
>>     * options.h (General_options): Add --no-rosegment option.
>>
>> This is OK.
>>
>> (Sorry for the delay. I'm still working on getting back into the
>> regular routine.)
>>
>> -cary
>
>
> Can you commit it for me:)
>
> I don't have commit permission.