From: YunQiang Su <syq@debian.org>
To: Alan Modra <amodra@gmail.com>
Cc: YunQiang Su <yunqiang.su@cipunited.com>,
binutils@sourceware.org, macro@orcam.me.uk, xry111@xry111.site,
richard.sandiford@arm.com, jiaxun.yang@flygoat.com
Subject: Re: [PATCH v2 0/5] Some MIPS changes and testsuite fixes
Date: Wed, 31 May 2023 16:17:27 +0800 [thread overview]
Message-ID: <CAKcpw6V8zJjwnX9C8Z1xf4wQ=Jc7sUKrnRYEdBCv=R1Ho7==yg@mail.gmail.com> (raw)
In-Reply-To: <ZGQQfi0oHT0YTyAp@squeak.grove.modra.org>
Alan Modra <amodra@gmail.com> 于2023年5月17日周三 07:23写道：
>
> On Tue, May 16, 2023 at 10:54:21AM +0800, YunQiang Su wrote:
> > Run testsuite with targets:
> > mipsisa32-linux-gnu mipsisa32r2-linux-gnu mips-linux-gnu
> > mipsisa32el-linux-gnu mipsisa32r2el-linux-gnu mipsel-linux-gnu
> > mipsisa32r6-linux-gnu mipsisa32r6el-linux-gnu
> > mips-img-linux-gnu mipsel-img-linux-gnu
> > mips-img-elf mipsel-img-elf
> > mips-mti-elf mipsel-mti-elf
> > mips64-linux-gnu mips64el-linux-gnu
> > mipsisa64-linux-gnu mipsisa64el-linux-gnu
> > mipsisa64r2-linux-gnu mipsisa64r2el-linux-gnu
> > mipsisa64r6-linux-gnu mipsisa64r6el-linux-gnu
> > mips64el-linux-gnuabi64 mips64-linux-gnuabi64
> > mipsisa64-linux-gnuabi64 mipsisa64el-linux-gnuabi64
> > mipsisa64r2el-linux-gnuabi64 mipsisa64r2-linux-gnuabi64
> > mipsisa64r6el-linux-gnuabi64 mipsisa64r6-linux-gnuabi64
>
> I applied your patchset and ran my usual regression tests over some
> 165 different binutils targets. mipsisa32r2el-elf, mips-sgi-irix6,
> and mipstx39-elf show some new failures. This doesn't mean I
> disapprove the patch, in fact I like it! Please don't think you must
> post another version of the patchset to fix these problems. It might
> be better to solve them with an incremental patch, giving the mips
> maintainers a chance to review this patchset first.
>
If there is no objection, I will commit this patchset and go on to solve
the problem Alan pointed out.
> Most of the mipsisa32r2el-elf fails are like this:
> failed with: <Assembler messages:
> Fatal error: selected target format 'elf32-nlittlemips' unknown>
> FAIL: MIPS RM7000 workarounds test 2 (micromips)
>
> Similarly, mipstx39-elf fails with
> Fatal error: selected target format 'elf32-nbigmips' unknown
>
> This one (one of the two mips-sgi-irix6 fails I saw) also appear with
> mipsisa32r2el-elf and mips-sgi-irix6:
> mips-sgi-irix6 +FAIL: MIPS ELF o32 PIC comdat GOT16/LO16 relocation pairing
>
> regexp_diff match failure
> regexp "^0000000c 0000070a R_MIPS_PC16 00000020 \.L1\^B1$"
> line "0000000c 00000d0a R_MIPS_PC16 00000020 .L1^B1"
> regexp_diff match failure
> regexp "^00000020 0000080a R_MIPS_PC16 00000018 \.L0\^B1$"
> line "00000020 00000e0a R_MIPS_PC16 00000018 .L0^B1"
> FAIL: MIPS ELF o32 PIC comdat GOT16/LO16 relocation pairing
>
> So that one is caused by different symbol table ordering.
>
> --
> Alan Modra
> Australia Development Lab, IBM
next prev parent reply other threads:[~2023-05-31 8:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 2:54 YunQiang Su
2023-05-16 2:54 ` [PATCH v2 1/5] MIPS: gas: alter 64 or 32 for mipsisa triples if march is implicit YunQiang Su
2023-05-16 2:54 ` [PATCH v2 2/5] MIPS: default r6 if vendor is img YunQiang Su
2023-05-16 2:54 ` [PATCH v2 3/5] MIPS: fix r6 testsuites YunQiang Su
2023-05-16 2:54 ` [PATCH v2 4/5] MIPS: fix -gnuabi64 testsuite YunQiang Su
2023-05-16 2:54 ` [PATCH v2 5/5] MIPS: fix some ld testcases with compiler YunQiang Su
2023-05-16 23:23 ` [PATCH v2 0/5] Some MIPS changes and testsuite fixes Alan Modra
2023-05-31 8:17 ` YunQiang Su [this message]
2023-05-31 11:09 ` Maciej W. Rozycki
2023-06-15 3:51 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKcpw6V8zJjwnX9C8Z1xf4wQ=Jc7sUKrnRYEdBCv=R1Ho7==yg@mail.gmail.com' \
--to=syq@debian.org \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=jiaxun.yang@flygoat.com \
--cc=macro@orcam.me.uk \
--cc=richard.sandiford@arm.com \
--cc=xry111@xry111.site \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).