From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: YunQiang Su <syq@debian.org>
Cc: Alan Modra <amodra@gmail.com>,
YunQiang Su <yunqiang.su@cipunited.com>,
binutils@sourceware.org, xry111@xry111.site,
richard.sandiford@arm.com, jiaxun.yang@flygoat.com
Subject: Re: [PATCH v2 0/5] Some MIPS changes and testsuite fixes
Date: Thu, 15 Jun 2023 04:51:07 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2306150013020.64925@angie.orcam.me.uk> (raw)
In-Reply-To: <alpine.DEB.2.21.2305311208250.14435@angie.orcam.me.uk>
On Wed, 31 May 2023, Maciej W. Rozycki wrote:
> > > I applied your patchset and ran my usual regression tests over some
> > > 165 different binutils targets. mipsisa32r2el-elf, mips-sgi-irix6,
> > > and mipstx39-elf show some new failures. This doesn't mean I
> > > disapprove the patch, in fact I like it! Please don't think you must
> > > post another version of the patchset to fix these problems. It might
> > > be better to solve them with an incremental patch, giving the mips
> > > maintainers a chance to review this patchset first.
> >
> > If there is no objection, I will commit this patchset and go on to solve
> > the problem Alan pointed out.
>
> Well, it does have to be reviewed, especially as there are changes beyond
> just testsuite fixes.
I have now reverted these changes, as they were committed unapproved and
I haven't heard back from you in response to my question sent off list.
If you want this patch set in, then please repost it, get reviewed *and*
approved, and only then you can commit it. Thank you.
Maciej
prev parent reply other threads:[~2023-06-15 3:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 2:54 YunQiang Su
2023-05-16 2:54 ` [PATCH v2 1/5] MIPS: gas: alter 64 or 32 for mipsisa triples if march is implicit YunQiang Su
2023-05-16 2:54 ` [PATCH v2 2/5] MIPS: default r6 if vendor is img YunQiang Su
2023-05-16 2:54 ` [PATCH v2 3/5] MIPS: fix r6 testsuites YunQiang Su
2023-05-16 2:54 ` [PATCH v2 4/5] MIPS: fix -gnuabi64 testsuite YunQiang Su
2023-05-16 2:54 ` [PATCH v2 5/5] MIPS: fix some ld testcases with compiler YunQiang Su
2023-05-16 23:23 ` [PATCH v2 0/5] Some MIPS changes and testsuite fixes Alan Modra
2023-05-31 8:17 ` YunQiang Su
2023-05-31 11:09 ` Maciej W. Rozycki
2023-06-15 3:51 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2306150013020.64925@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=jiaxun.yang@flygoat.com \
--cc=richard.sandiford@arm.com \
--cc=syq@debian.org \
--cc=xry111@xry111.site \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).