[PATCH v3 1/2] Gold/MIPS: Improve MIPS support in configure.tgt

[PATCH v3 1/2] Gold/MIPS: Improve MIPS support in configure.tgt

[YunQiang Su]

1. Drop mips*le triple pattern, which will consider as big endian
   by other components of binutils.
2. Use EM_MIPS instead of EM_MIPS_RS3_LE for little endian.
   EM_MIPS_RS3_LE has been deprecated quite long ago, and in fact
   most of current LE ELF files are using EM_MIPS.
3. Add targ_extra_size=64 for mips32 triples.
4. Add targ_extra_little_endian=true for big endian triples.
5. Add mips64 triples support, and define targ_extra_little_endian/
   targ_extra_big_endian, and targ_extra_size=32.

Let's use `targ_extra_little_endian` in configure.ac/configure,
so that littlen endian can be enabled if the targets are all big endian.
---
 gold/configure     |  8 ++++++++
 gold/configure.ac  |  8 ++++++++
 gold/configure.tgt | 24 +++++++++++++++++++++---
 3 files changed, 37 insertions(+), 3 deletions(-)

diff --git a/gold/configure b/gold/configure
index 5c6fe2a5607..ccb1f2269b2 100755
--- a/gold/configure
+++ b/gold/configure
@@ -5266,6 +5266,10 @@ for targ in $target $canon_targets; do
 	      -o "$targ_extra_big_endian" = "true"; then
 	      targ_32_big=yes
 	  fi
+	  if test "$targ_little_endian" = "true" \
+	      -o "$targ_extra_little_endian" = "true"; then
+	      targ_32_little=yes
+	  fi
 	  if test "$targ_big_endian" = "false" \
 	      -o "$targ_extra_big_endian" = "false"; then
 	      targ_32_little=yes
@@ -5276,6 +5280,10 @@ for targ in $target $canon_targets; do
 	      -o "$targ_extra_big_endian" = "true"; then
 	      targ_64_big=yes
 	  fi
+	  if test "$targ_little_endian" = "true" \
+	      -o "$targ_extra_little_endian" = "true"; then
+	      targ_64_little=yes
+	  fi
 	  if test "$targ_big_endian" = "false" \
 	      -o "$targ_extra_big_endian" = "false"; then
 	      targ_64_little=yes
diff --git a/gold/configure.ac b/gold/configure.ac
index cafd3503b3b..e04e4086140 100644
--- a/gold/configure.ac
+++ b/gold/configure.ac
@@ -193,6 +193,10 @@ for targ in $target $canon_targets; do
 	      -o "$targ_extra_big_endian" = "true"; then
 	      targ_32_big=yes
 	  fi
+	  if test "$targ_little_endian" = "true" \
+	      -o "$targ_extra_little_endian" = "true"; then
+	      targ_32_little=yes
+	  fi
 	  if test "$targ_big_endian" = "false" \
 	      -o "$targ_extra_big_endian" = "false"; then
 	      targ_32_little=yes
@@ -203,6 +207,10 @@ for targ in $target $canon_targets; do
 	      -o "$targ_extra_big_endian" = "true"; then
 	      targ_64_big=yes
 	  fi
+	  if test "$targ_little_endian" = "true" \
+	      -o "$targ_extra_little_endian" = "true"; then
+	      targ_64_little=yes
+	  fi
 	  if test "$targ_big_endian" = "false" \
 	      -o "$targ_extra_big_endian" = "false"; then
 	      targ_64_little=yes
diff --git a/gold/configure.tgt b/gold/configure.tgt
index 4b54e08d27f..e2e131bbd84 100644
--- a/gold/configure.tgt
+++ b/gold/configure.tgt
@@ -153,19 +153,37 @@ aarch64*-*)
  targ_big_endian=false
  targ_extra_big_endian=true
  ;;
-mips*el*-*-*|mips*le*-*-*)
+mips64*el-*-*)
  targ_obj=mips
- targ_machine=EM_MIPS_RS3_LE
+ targ_machine=EM_MIPS
+ targ_size=64
+ targ_extra_size=32
+ targ_big_endian=false
+ targ_extra_big_endian=true
+ ;;
+mips*el-*-*)
+ targ_obj=mips
+ targ_machine=EM_MIPS
  targ_size=32
+ targ_extra_size=64
  targ_big_endian=false
  targ_extra_big_endian=true
  ;;
+mips64*-*-*)
+ targ_obj=mips
+ targ_machine=EM_MIPS
+ targ_size=64
+ targ_extra_size=32
+ targ_big_endian=true
+ targ_extra_little_endian=true
+ ;;
 mips*-*-*)
  targ_obj=mips
  targ_machine=EM_MIPS
  targ_size=32
+ targ_extra_size=64
  targ_big_endian=true
- targ_extra_big_endian=false
+ targ_extra_little_endian=true
  ;;
 s390-*-*)
  targ_obj=s390
-- 
2.30.2

[PATCH v3 2/2] MIPS: Use 64-bit a ABI by default for `mipsisa64*-*-linux*' targets

[YunQiang Su]

Following the arrangement in GCC select a 64-bit ABI by default, either
n32 or n64, rather than o32 for `mipsisa64*-*-linux*' targets, just as
with the corresponding `mips64*-*-linux*' targets.
---
 bfd/config.bfd     |  8 ++++----
 gas/configure      |  6 +++---
 gas/configure.ac   |  6 +++---
 gold/configure.tgt |  4 ++--
 ld/configure.tgt   | 10 ++++++----
 5 files changed, 18 insertions(+), 16 deletions(-)

diff --git a/bfd/config.bfd b/bfd/config.bfd
index 29f1c77e11f..5ffbd30139a 100644
--- a/bfd/config.bfd
+++ b/bfd/config.bfd
@@ -957,21 +957,21 @@ case "${targ}" in
     targ_defvec=mips_elf32_be_vec
     targ_selvecs="mips_elf32_le_vec mips_elf64_be_vec mips_elf64_le_vec mips_ecoff_be_vec mips_ecoff_le_vec"
     ;;
-  mips64*el-*-linux*-gnuabi64)
+  mips64*el-*-linux*-gnuabi64 | mipsisa64*el-*-linux*-gnuabi64)
     targ_defvec=mips_elf64_trad_le_vec
     targ_selvecs="mips_elf64_trad_be_vec mips_elf32_ntrad_le_vec mips_elf32_ntrad_be_vec mips_elf32_trad_le_vec mips_elf32_trad_be_vec"
     want64=true
     ;;
-  mips64*el-*-linux*)
+  mips64*el-*-linux* | mipsisa64*el-*-linux*)
     targ_defvec=mips_elf32_ntrad_le_vec
     targ_selvecs="mips_elf32_ntrad_be_vec mips_elf32_trad_le_vec mips_elf32_trad_be_vec mips_elf64_trad_le_vec mips_elf64_trad_be_vec"
     ;;
-  mips64*-*-linux*-gnuabi64)
+  mips64*-*-linux*-gnuabi64 | mipsisa64*-*-linux*-gnuabi64)
     targ_defvec=mips_elf64_trad_be_vec
     targ_selvecs="mips_elf64_trad_le_vec mips_elf32_ntrad_be_vec mips_elf32_ntrad_le_vec mips_elf32_trad_be_vec mips_elf32_trad_le_vec"
     want64=true
     ;;
-  mips64*-*-linux*)
+  mips64*-*-linux* | mipsisa64*-*-linux*)
     targ_defvec=mips_elf32_ntrad_be_vec
     targ_selvecs="mips_elf32_ntrad_le_vec mips_elf32_trad_be_vec mips_elf32_trad_le_vec mips_elf64_trad_be_vec mips_elf64_trad_le_vec"
     ;;
diff --git a/gas/configure b/gas/configure
index 3c80fe5741a..1827e38690e 100755
--- a/gas/configure
+++ b/gas/configure
@@ -12256,11 +12256,11 @@ _ACEOF
 	esac
 	# Decide which ABI to target by default.
 	case ${target} in
-	  mips64*-openbsd* | mips64*-linux-gnuabi64)
+	  mips64*-openbsd* | mips64*-linux-gnuabi64 | mipsisa64*-linux-gnuabi64)
 	    mips_default_abi=N64_ABI
 	    ;;
-	  mips64*-linux* | mips-sgi-irix6* | mips64*-freebsd* \
-	  | mips64*-kfreebsd*-gnu | mips64*-ps2-elf*)
+	  mips64*-linux* | mipsisa64*-linux* | mips-sgi-irix6* \
+	  | mips64*-freebsd* | mips64*-kfreebsd*-gnu | mips64*-ps2-elf*)
 	    mips_default_abi=N32_ABI
 	    ;;
 	  mips*-linux* | mips*-freebsd* | mips*-kfreebsd*-gnu)
diff --git a/gas/configure.ac b/gas/configure.ac
index 3a04c39d344..ecfab6bf510 100644
--- a/gas/configure.ac
+++ b/gas/configure.ac
@@ -394,11 +394,11 @@ changequote([,])dnl
 	esac
 	# Decide which ABI to target by default.
 	case ${target} in
-	  mips64*-openbsd* | mips64*-linux-gnuabi64)
+	  mips64*-openbsd* | mips64*-linux-gnuabi64 | mipsisa64*-linux-gnuabi64)
 	    mips_default_abi=N64_ABI
 	    ;;
-	  mips64*-linux* | mips-sgi-irix6* | mips64*-freebsd* \
-	  | mips64*-kfreebsd*-gnu | mips64*-ps2-elf*)
+	  mips64*-linux* | mipsisa64*-linux* | mips-sgi-irix6* \
+	  | mips64*-freebsd* | mips64*-kfreebsd*-gnu | mips64*-ps2-elf*)
 	    mips_default_abi=N32_ABI
 	    ;;
 	  mips*-linux* | mips*-freebsd* | mips*-kfreebsd*-gnu)
diff --git a/gold/configure.tgt b/gold/configure.tgt
index e2e131bbd84..99a5fcc91ee 100644
--- a/gold/configure.tgt
+++ b/gold/configure.tgt
@@ -153,7 +153,7 @@ aarch64*-*)
  targ_big_endian=false
  targ_extra_big_endian=true
  ;;
-mips64*el-*-*)
+mips64*el-*-* | mipsisa64*el-linux*)
  targ_obj=mips
  targ_machine=EM_MIPS
  targ_size=64
@@ -169,7 +169,7 @@ mips*el-*-*)
  targ_big_endian=false
  targ_extra_big_endian=true
  ;;
-mips64*-*-*)
+mips64*-*-* | mipsisa64*-linux*)
  targ_obj=mips
  targ_machine=EM_MIPS
  targ_size=64
diff --git a/ld/configure.tgt b/ld/configure.tgt
index f78ba07e5ca..92b1ac8f95a 100644
--- a/ld/configure.tgt
+++ b/ld/configure.tgt
@@ -585,21 +585,23 @@ mips*-*-vxworks*)	targ_emul=elf32ebmipvxworks
 			;;
 mips*-*-windiss)	targ_emul=elf32mipswindiss
 			;;
-mips64*el-*-linux-gnuabi64)
+mips64*el-*-linux-gnuabi64 | mipsisa64*el-*-linux-gnuabi64)
 			targ_emul=elf64ltsmip
 			targ_extra_emuls="elf64btsmip elf32ltsmipn32 elf32btsmipn32 elf32ltsmip elf32btsmip"
 			targ_extra_libpath=$targ_extra_emuls
 			;;
-mips64*el-*-linux-*)	targ_emul=elf32ltsmipn32
+mips64*el-*-linux-* | mipsisa64*el-*-linux-*)
+			targ_emul=elf32ltsmipn32
 			targ_extra_emuls="elf32btsmipn32 elf32ltsmip elf32btsmip elf64ltsmip elf64btsmip"
 			targ_extra_libpath=$targ_extra_emuls
 			;;
-mips64*-*-linux-gnuabi64)
+mips64*-*-linux-gnuabi64 | mipsisa64*-*-linux-gnuabi64)
 			targ_emul=elf64btsmip
 			targ_extra_emuls="elf64ltsmip elf32btsmipn32 elf32ltsmipn32 elf32btsmip elf32ltsmip"
 			targ_extra_libpath=$targ_extra_emuls
 			;;
-mips64*-*-linux-*)	targ_emul=elf32btsmipn32
+mips64*-*-linux-* | mipsisa64*-*-linux-*)
+			targ_emul=elf32btsmipn32
 			targ_extra_emuls="elf32ltsmipn32 elf32btsmip elf32ltsmip elf64btsmip elf64ltsmip"
 			targ_extra_libpath=$targ_extra_emuls
 			;;
-- 
2.30.2

Re: [PATCH v3 1/2] Gold/MIPS: Improve MIPS support in configure.tgt

[YunQiang Su]

@Maciej W. Rozycki How about this patch?

@Nick Clifton Is there any policy of backport policy of 2.41?
If OK, I'd like to backport this patch to 2.41. As it is really a bug:
   ../configure --enable-targets=mipsel-linux-gnu only will fail to build.

See:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1049455
and
https://buildd.debian.org/status/fetch.php?pkg=binutils-mipsen&arch=amd64&ver=10%2Bc5&stamp=1692086940&raw=0

Re: [PATCH v3 1/2] Gold/MIPS: Improve MIPS support in configure.tgt

[Maciej W. Rozycki]

On Fri, 25 Aug 2023, YunQiang Su wrote:

> @Maciej W. Rozycki How about this patch?

 This will have to be split as I previously outlined.  Also I won't have 
any time to review patches in the next few weeks as I am out of capacity 
right now.

  Maciej

Re: [PATCH v3 1/2] Gold/MIPS: Improve MIPS support in configure.tgt

[YunQiang Su]

Maciej W. Rozycki <macro@orcam.me.uk> 于2023年8月25日周五 11:31写道：
>
> On Fri, 25 Aug 2023, YunQiang Su wrote:
>
> > @Maciej W. Rozycki How about this patch?
>
>  This will have to be split as I previously outlined.  Also I won't have

Generally, we should split patches by code logic, instead of make it fragments.
For distrubutions, cherry-pick patches from master is needed usally.
Fragmental patches will make lots of trobule to them.

We should have a trade off, instead of be extrame.

> any time to review patches in the next few weeks as I am out of capacity
> right now.
>
>   Maciej



-- 
YunQiang Su