From: YunQiang Su <syq@debian.org>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Paul Hua <paul.hua.gm@gmail.com>, binutils@sourceware.org
Subject: Re: [PATCH][MIPS][Committed] Fix PR/gas 25539 fix_loongson3_llsc: fix when target has multi labels
Date: Tue, 17 Mar 2020 10:08:38 +0800 [thread overview]
Message-ID: <CAKcpw6W6zh4SFpLf7tUr6zXxw5vrg11fr=DpB6Gw37MVq3zmCw@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.21.2003170137500.1745527@eddie.linux-mips.org>
Maciej W. Rozycki <macro@linux-mips.org> 于2020年3月17日周二 上午9:49写道：
>
> On Fri, 28 Feb 2020, Paul Hua wrote:
>
> > When there is multi-labels on the same insn, the current code
> > will take care about the last one. it may cause that no sync
> > is added at the target.
>
> Why do you need to set an arbitrary limit as to the number of labels
> handled (MAX_LABELS_SAME)? This handles user-supplied input, so we can't
Yes. It is a problem. I did it fellow the scheme as MAX_LLSC_RANGE.
Maybe that we should use dynamic allocated memory to hold both of them.
> predict how many there will be at most. What happens if the limit has
> been exceeded?
If exceeded the workaround won't work, aka no `sync' will be insert in
this case.
>
> We should avoid setting unnecessary limits, as per our coding standards:
> <https://www.gnu.org/prep/standards/standards.html#Semantics>.
>
> Maciej
prev parent reply other threads:[~2020-03-17 2:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 9:38 Paul Hua
2020-03-17 1:42 ` Maciej W. Rozycki
2020-03-17 2:08 ` YunQiang Su [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKcpw6W6zh4SFpLf7tUr6zXxw5vrg11fr=DpB6Gw37MVq3zmCw@mail.gmail.com' \
--to=syq@debian.org \
--cc=binutils@sourceware.org \
--cc=macro@linux-mips.org \
--cc=paul.hua.gm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).