From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Paul Hua <paul.hua.gm@gmail.com>
Cc: binutils@sourceware.org, syq@debian.org
Subject: Re: [PATCH][MIPS][Committed] Fix PR/gas 25539 fix_loongson3_llsc: fix when target has multi labels
Date: Tue, 17 Mar 2020 01:42:35 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.21.2003170137500.1745527@eddie.linux-mips.org> (raw)
In-Reply-To: <CAKjxQH=O527ozfGmHHj_B6X-AZs8LWfg--_-6G97LvLF68UeSA@mail.gmail.com>
On Fri, 28 Feb 2020, Paul Hua wrote:
> When there is multi-labels on the same insn, the current code
> will take care about the last one. it may cause that no sync
> is added at the target.
Why do you need to set an arbitrary limit as to the number of labels
handled (MAX_LABELS_SAME)? This handles user-supplied input, so we can't
predict how many there will be at most. What happens if the limit has
been exceeded?
We should avoid setting unnecessary limits, as per our coding standards:
<https://www.gnu.org/prep/standards/standards.html#Semantics>.
Maciej
next prev parent reply other threads:[~2020-03-17 1:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 9:38 Paul Hua
2020-03-17 1:42 ` Maciej W. Rozycki [this message]
2020-03-17 2:08 ` YunQiang Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2003170137500.1745527@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=binutils@sourceware.org \
--cc=paul.hua.gm@gmail.com \
--cc=syq@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).