public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: YunQiang Su <syq@debian.org>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: YunQiang Su <yunqiang.su@cipunited.com>,
	binutils@sourceware.org, xry111@xry111.site,
	 richard.sandiford@arm.com, jiaxun.yang@flygoat.com
Subject: Re: [PATCH] MIPS: add MT ASE support for micromips32
Date: Tue, 16 May 2023 14:32:38 +0800	[thread overview]
Message-ID: <CAKcpw6Wq7p28iV_vd7wuKxYJ7Ar-fz597YtZaRAm9uPPQ5vVtw@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2304251059540.58739@angie.orcam.me.uk>

Maciej W. Rozycki <macro@orcam.me.uk> 于2023年4月25日周二 18:03写道:
>
> On Tue, 25 Apr 2023, YunQiang Su wrote:
>
> > diff --git a/opcodes/micromips-opc.c b/opcodes/micromips-opc.c
> > index 94812a68c82..5a6460d9b8b 100644
> > --- a/opcodes/micromips-opc.c
> > +++ b/opcodes/micromips-opc.c
> > @@ -148,6 +148,10 @@ decode_micromips_operand (const char *p)
> >      case '~': SINT (12, 0);
> >      case '@': SINT (10, 16);
> >      case '^': HINT (5, 11);
> > +    case '*': REG (2, 23, ACC);
> > +    case '!': UINT (1, 10);
> > +    case '$': UINT (1, 9);
> > +    case '&': REG (2, 18, ACC);
> >
> >      case '0': SINT (6, 16);
> >      case '1': HINT (5, 16);
> > @@ -165,6 +169,7 @@ decode_micromips_operand (const char *p)
> >      case 'G': REG (5, 16, COPRO);
> >      case 'K': REG (5, 16, HW);
> >      case 'H': UINT (3, 11);
> > +    case 'O': UINT (3, 4);
> >      case 'M': REG (3, 13, CCC);
> >      case 'N': REG (3, 18, CCC);
> >      case 'R': REG (5, 6, FP);
>
>  When adding new operand formats you need to document them in
> include/opcode/mips.h.  NB this is not a full review.
>

Any update?

>   Maciej

  parent reply	other threads:[~2023-05-16  6:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25  6:56 YunQiang Su
2023-04-25 10:02 ` Maciej W. Rozycki
2023-04-25 10:20   ` YunQiang Su
2023-04-25 10:25     ` YunQiang Su
2023-04-25 10:45     ` Maciej W. Rozycki
2023-05-16  6:32   ` YunQiang Su [this message]
2023-05-31  8:15     ` YunQiang Su
2023-05-31 10:28       ` Maciej W. Rozycki
2023-06-15  3:50         ` Maciej W. Rozycki
2023-04-26 10:16 ` [PATCH v2 1/2] " YunQiang Su
2023-04-26 10:16   ` [PATCH v2 2/2] MIPS: sync oprand char usage between mips and micromips YunQiang Su
2023-06-15  3:49     ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKcpw6Wq7p28iV_vd7wuKxYJ7Ar-fz597YtZaRAm9uPPQ5vVtw@mail.gmail.com \
    --to=syq@debian.org \
    --cc=binutils@sourceware.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=macro@orcam.me.uk \
    --cc=richard.sandiford@arm.com \
    --cc=xry111@xry111.site \
    --cc=yunqiang.su@cipunited.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).