public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: YunQiang Su <syq@debian.org>
Cc: YunQiang Su <yunqiang.su@cipunited.com>,
	binutils@sourceware.org,  xry111@xry111.site,
	richard.sandiford@arm.com, jiaxun.yang@flygoat.com
Subject: Re: [PATCH] MIPS: add MT ASE support for micromips32
Date: Tue, 25 Apr 2023 11:45:00 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2304251137430.58739@angie.orcam.me.uk> (raw)
In-Reply-To: <CAKcpw6Xc=iM3XMfwQt+DSo4TC2Qj=a2eF9KRmfvWU1rNxqkSTQ@mail.gmail.com>

On Tue, 25 Apr 2023, YunQiang Su wrote:

> >  When adding new operand formats you need to document them in
> > include/opcode/mips.h.  NB this is not a full review.
> >
> Thank you. Are these lines OK for it?
> 
>    DSP ASE usage:
>    "*" 2-bit unsigned immediate in rt section for MFTR
>    "&" 2-bit unsigned immediate in rs section for MTTR
>    "!" 1-bit 'u' value in MFTR/MTTR
>    "$" 1-bit 'h' value in MFTR/MTTR
>    "O" 3-bit 'sel' value in MFTR/MTTR

 I suggest that you borrow the wording from the regular MIPS section, 
which describes the meaning of the opcode fields and not just the raw 
encoding.  Also you need to update character usage tables.

  Maciej

  parent reply	other threads:[~2023-04-25 10:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25  6:56 YunQiang Su
2023-04-25 10:02 ` Maciej W. Rozycki
2023-04-25 10:20   ` YunQiang Su
2023-04-25 10:25     ` YunQiang Su
2023-04-25 10:45     ` Maciej W. Rozycki [this message]
2023-05-16  6:32   ` YunQiang Su
2023-05-31  8:15     ` YunQiang Su
2023-05-31 10:28       ` Maciej W. Rozycki
2023-06-15  3:50         ` Maciej W. Rozycki
2023-04-26 10:16 ` [PATCH v2 1/2] " YunQiang Su
2023-04-26 10:16   ` [PATCH v2 2/2] MIPS: sync oprand char usage between mips and micromips YunQiang Su
2023-06-15  3:49     ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2304251137430.58739@angie.orcam.me.uk \
    --to=macro@orcam.me.uk \
    --cc=binutils@sourceware.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=richard.sandiford@arm.com \
    --cc=syq@debian.org \
    --cc=xry111@xry111.site \
    --cc=yunqiang.su@cipunited.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).