From: Kito Cheng <kito.cheng@sifive.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: Nelson Chu <nelson@rivosinc.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
binutils@sourceware.org
Subject: Re: [PATCH 1/2] RISC-V: Remove RV64E conflict
Date: Tue, 25 Jul 2023 21:27:41 +0800 [thread overview]
Message-ID: <CALLt3Tg3YsiCvpQr4gFCwOWpkZ2_3Wg_x-DV3mMcntn=QLsC9Q@mail.gmail.com> (raw)
In-Reply-To: <8082a035470d6f4c204cc5c0a45ff5ab2394d136.1690251857.git.research_trasio@irq.a4lg.com>
Reviewed-by: Kito Cheng <kito.cheng@sifive.com>
On Tue, Jul 25, 2023 at 10:27 AM Tsukasa OI
<research_trasio@irq.a4lg.com> wrote:
>
> From: Tsukasa OI <research_trasio@irq.a4lg.com>
>
> Since RV32E *and* RV64E are ratified, RV64E is no longer invalid.
>
> This commit removes a restriction that prevents making base ISA with
> reduced GPRs with XLEN > 32.
>
> bfd/ChangeLog:
>
> * elfxx-riscv.c (riscv_parse_check_conflicts): Remove RV64E
> conflict since the ratified 'E' base ISAs include RV64E.
>
> gas/ChangeLog:
>
> * testsuite/gas/riscv/march-fail-base-02.d: Removed.
> * testsuite/gas/riscv/march-fail-base-02.l: Removed.
> ---
> bfd/elfxx-riscv.c | 7 -------
> gas/testsuite/gas/riscv/march-fail-base-02.d | 3 ---
> gas/testsuite/gas/riscv/march-fail-base-02.l | 2 --
> 3 files changed, 12 deletions(-)
> delete mode 100644 gas/testsuite/gas/riscv/march-fail-base-02.d
> delete mode 100644 gas/testsuite/gas/riscv/march-fail-base-02.l
>
> diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
> index b43d2cfa0fab..205dd0766abe 100644
> --- a/bfd/elfxx-riscv.c
> +++ b/bfd/elfxx-riscv.c
> @@ -1933,13 +1933,6 @@ riscv_parse_check_conflicts (riscv_parse_subset_t *rps)
> int xlen = *rps->xlen;
> bool no_conflict = true;
>
> - if (riscv_lookup_subset (rps->subset_list, "e", &subset)
> - && xlen > 32)
> - {
> - rps->error_handler
> - (_("rv%d does not support the `e' extension"), xlen);
> - no_conflict = false;
> - }
> if (riscv_lookup_subset (rps->subset_list, "q", &subset)
> && (subset->major_version < 2 || (subset->major_version == 2
> && subset->minor_version < 2))
> diff --git a/gas/testsuite/gas/riscv/march-fail-base-02.d b/gas/testsuite/gas/riscv/march-fail-base-02.d
> deleted file mode 100644
> index cfe085ab21aa..000000000000
> --- a/gas/testsuite/gas/riscv/march-fail-base-02.d
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -#as: -march=rv64e
> -#source: empty.s
> -#error_output: march-fail-base-02.l
> diff --git a/gas/testsuite/gas/riscv/march-fail-base-02.l b/gas/testsuite/gas/riscv/march-fail-base-02.l
> deleted file mode 100644
> index 52fee96af368..000000000000
> --- a/gas/testsuite/gas/riscv/march-fail-base-02.l
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -.*Assembler messages:
> -.*Error: rv64 does not support the `e' extension
> --
> 2.41.0
>
next prev parent reply other threads:[~2023-07-25 13:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 2:26 [PATCH 0/2] RISC-V: Add ratified 'E' base ISA support with draft ABIs Tsukasa OI
2023-07-25 2:26 ` [PATCH 1/2] RISC-V: Remove RV64E conflict Tsukasa OI
2023-07-25 13:27 ` Kito Cheng [this message]
2023-07-25 2:26 ` [PATCH 2/2] RISC-V: Add "lp64e" ABI support Tsukasa OI
2023-07-25 13:27 ` Kito Cheng
2023-08-31 3:21 ` [PATCH v2 0/3] RISC-V: Add ratified 'E' base ISA support with draft ABIs Tsukasa OI
2023-08-31 3:21 ` [PATCH v2 1/3] RISC-V: Remove RV64E conflict Tsukasa OI
2023-08-31 3:21 ` [PATCH v2 2/3] RISC-V: Add "lp64e" ABI support Tsukasa OI
2023-08-31 3:21 ` [PATCH v2 3/3] RISC-V: Add RV64E support to GDB Tsukasa OI
2023-09-05 9:08 ` [PATCH v3 0/3] RISC-V: Add ratified 'E' base ISA support with draft ABIs Tsukasa OI
2023-09-05 9:08 ` [PATCH v3 1/3] RISC-V: Remove RV64E conflict Tsukasa OI
2023-09-05 9:08 ` [PATCH v3 2/3] RISC-V: Add "lp64e" ABI support Tsukasa OI
2023-09-05 9:08 ` [PATCH v3 3/3] RISC-V: Add RV64E support to GDB Tsukasa OI
2023-09-25 3:07 ` [PATCH v3 0/3] RISC-V: Add ratified 'E' base ISA support with draft ABIs Nelson Chu
2023-09-25 8:04 ` Tsukasa OI
2023-10-16 8:20 ` Tsukasa OI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALLt3Tg3YsiCvpQr4gFCwOWpkZ2_3Wg_x-DV3mMcntn=QLsC9Q@mail.gmail.com' \
--to=kito.cheng@sifive.com \
--cc=binutils@sourceware.org \
--cc=nelson@rivosinc.com \
--cc=palmer@dabbelt.com \
--cc=research_trasio@irq.a4lg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).