Re: [committed v2] MIPS/opcodes: Fix alias annotation for branch instructions

[Sagar Patel <sagarmp@cs.unc.edu>]

On Sun, Mar 6, 2022 at 1:33 PM Maciej W. Rozycki <macro@orcam.me.uk> wrote:
>
>  Last but not least your change does not include a testsuite update and
> yet it does not cause regressions with testing despite the semantic
> change.  That means we don't have this area covered.
>
>  Here's what I have committed then, addressing the issues listed above.
> I have added the missing ChangeLog entry too and rewritten the change
> heading and description accordingly.

Thanks for explaining how to format future patches. I didn't think to
update the test suite (since I didn't know it existed). I'll update
the ChangeLog, and include it in the commit message in the future.

>  NB I can see you have not contributed before and your patch is very
> small, affecting 4 lines of code only, which qualifies as not a legally
> significant change.  If you wish to continue contributing to binutils
> project however, then please consider getting a copyright assignment
> signed with FSF, as this will allow you to make changes beyond the limit
> of ~15 lines of code total, which these 4 lines count against too.  Nick,
> the head binutils maintainer (cc-ed), will get you introduced if you would
> like to follow this path.

I have another patch that has a larger diff teed up, so I guess I'll
need to look into copyright assignment. Is there an easy way to assign
copyright as changes are submitted, instead of assigning it for all
future changes?

It would be great if this project could drop the copyright assignment
requirement like gcc [1]. This would certainly reduce friction in the
process of contributing. (I know you're probably not the person that
makes these decisions. Just putting this out there.)

>  Again, thank you for your contribution, your input is valuable.

Thank you! I appreciate your guidance :)

[1]: https://lwn.net/Articles/857791/

---Sagar Patel