From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH] x86: correct CPU_AMX_{BF16,INT8}_FLAGS
Date: Mon, 17 Oct 2022 15:24:16 -0700 [thread overview]
Message-ID: <CAMe9rOo2m4vnK0eqFZ-3hCuDmmReBeC0q=6=getPbm0ntQki6w@mail.gmail.com> (raw)
In-Reply-To: <19c08747-fa5b-1e67-3dd2-c891a2c0c1fa@suse.com>
On Mon, Oct 17, 2022 at 12:44 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> AMX-TILE is a prereq to these, as already correctly expressed by
> CPU_ANY_AMX_TILE_FLAGS. Express the dependency also in the reverse
> ("positive") direction.
> ---
> Ideally we would teach i386-gen to at least check (better derive) such
> two-way dependencies.
>
> --- a/opcodes/i386-gen.c
> +++ b/opcodes/i386-gen.c
> @@ -303,9 +303,9 @@ static initializer cpu_flag_init[] =
> { "CPU_CLDEMOTE_FLAGS",
> "CpuCLDEMOTE" },
> { "CPU_AMX_INT8_FLAGS",
> - "CpuAMX_INT8" },
> + "CPU_AMX_TILE_FLAGS|CpuAMX_INT8" },
> { "CPU_AMX_BF16_FLAGS",
> - "CpuAMX_BF16" },
> + "CPU_AMX_TILE_FLAGS|CpuAMX_BF16" },
> { "CPU_AMX_TILE_FLAGS",
> "CpuAMX_TILE" },
> { "CPU_MOVDIRI_FLAGS",
OK.
Thanks.
--
H.J.
prev parent reply other threads:[~2022-10-17 22:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 7:44 Jan Beulich
2022-10-17 22:24 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOo2m4vnK0eqFZ-3hCuDmmReBeC0q=6=getPbm0ntQki6w@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).