* [PATCH] x86: correct CPU_AMX_{BF16,INT8}_FLAGS
@ 2022-10-17 7:44 Jan Beulich
2022-10-17 22:24 ` H.J. Lu
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2022-10-17 7:44 UTC (permalink / raw)
To: Binutils; +Cc: H.J. Lu
AMX-TILE is a prereq to these, as already correctly expressed by
CPU_ANY_AMX_TILE_FLAGS. Express the dependency also in the reverse
("positive") direction.
---
Ideally we would teach i386-gen to at least check (better derive) such
two-way dependencies.
--- a/opcodes/i386-gen.c
+++ b/opcodes/i386-gen.c
@@ -303,9 +303,9 @@ static initializer cpu_flag_init[] =
{ "CPU_CLDEMOTE_FLAGS",
"CpuCLDEMOTE" },
{ "CPU_AMX_INT8_FLAGS",
- "CpuAMX_INT8" },
+ "CPU_AMX_TILE_FLAGS|CpuAMX_INT8" },
{ "CPU_AMX_BF16_FLAGS",
- "CpuAMX_BF16" },
+ "CPU_AMX_TILE_FLAGS|CpuAMX_BF16" },
{ "CPU_AMX_TILE_FLAGS",
"CpuAMX_TILE" },
{ "CPU_MOVDIRI_FLAGS",
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: correct CPU_AMX_{BF16,INT8}_FLAGS
2022-10-17 7:44 [PATCH] x86: correct CPU_AMX_{BF16,INT8}_FLAGS Jan Beulich
@ 2022-10-17 22:24 ` H.J. Lu
0 siblings, 0 replies; 2+ messages in thread
From: H.J. Lu @ 2022-10-17 22:24 UTC (permalink / raw)
To: Jan Beulich; +Cc: Binutils
On Mon, Oct 17, 2022 at 12:44 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> AMX-TILE is a prereq to these, as already correctly expressed by
> CPU_ANY_AMX_TILE_FLAGS. Express the dependency also in the reverse
> ("positive") direction.
> ---
> Ideally we would teach i386-gen to at least check (better derive) such
> two-way dependencies.
>
> --- a/opcodes/i386-gen.c
> +++ b/opcodes/i386-gen.c
> @@ -303,9 +303,9 @@ static initializer cpu_flag_init[] =
> { "CPU_CLDEMOTE_FLAGS",
> "CpuCLDEMOTE" },
> { "CPU_AMX_INT8_FLAGS",
> - "CpuAMX_INT8" },
> + "CPU_AMX_TILE_FLAGS|CpuAMX_INT8" },
> { "CPU_AMX_BF16_FLAGS",
> - "CpuAMX_BF16" },
> + "CPU_AMX_TILE_FLAGS|CpuAMX_BF16" },
> { "CPU_AMX_TILE_FLAGS",
> "CpuAMX_TILE" },
> { "CPU_MOVDIRI_FLAGS",
OK.
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-17 22:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-17 7:44 [PATCH] x86: correct CPU_AMX_{BF16,INT8}_FLAGS Jan Beulich
2022-10-17 22:24 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).