From: "H.J. Lu" <hjl.tools@gmail.com>
To: Rainer Orth <ro@cebitec.uni-bielefeld.de>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] i386: Don't emit unsupported TLS relocs on Solaris [PR13671]
Date: Thu, 19 Jan 2023 13:55:39 -0800 [thread overview]
Message-ID: <CAMe9rOoi5jXposRjtK_CxiSxnNZibq+TTWGeVPtiVn3gPEKhAw@mail.gmail.com> (raw)
In-Reply-To: <yddbkmx8kt8.fsf@CeBiTec.Uni-Bielefeld.DE>
On Tue, Jan 17, 2023 at 3:25 AM Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>
> As detailed in PR ld/13671, gld can emit R_386_TLS_TPOFF32 relocs which
> the Solaris/x86 ld.so.1 doesn't know about, so the resulting executables
> won't run.
>
> The following patch, which H.J. provided in the PR, fixes this.
>
> Tested on i386-pc-solaris2.11 (both with the binutils testsuite and a
> full gcc bootstrap) and i686-pc-linux-gnu.
>
> Already approved by H.J. in the PR, but it's probably best if someone
> double-checks the ChangeLog entry.
>
> Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>
>
> 2023-01-17 H.J. Lu <hongjiu.lu@intel.com>
>
> bfd:
> PR ld/13671
> * elf32-i386.c (elf_i386_tls_transition): Only emit R_386_TLS_LE,
> R_386_TLS_IE on Solaris.
> (elf_i386_relocate_section): Only use R_386_TLS_GD->R_386_TLS_LE
> transition on Solaris.
>
I checked it in.
Thanks.
--
H.J.
next prev parent reply other threads:[~2023-01-19 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 11:25 Rainer Orth
2023-01-19 21:55 ` H.J. Lu [this message]
2023-01-20 8:10 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOoi5jXposRjtK_CxiSxnNZibq+TTWGeVPtiVn3gPEKhAw@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
--cc=ro@cebitec.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).