Re: [binutils-gdb] LTO: Handle __real_SYM reference in IR

Re: [binutils-gdb] LTO: Handle __real_SYM reference in IR

[H.J. Lu]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

On Wed, May 4, 2022 at 4:43 PM Alan Modra <amodra@gmail.com> wrote:
>
> On Wed, May 04, 2022 at 11:27:56PM +0000, H.J. Lu via Binutils-cvs wrote:
> > --- a/bfd/linker.c
> > +++ b/bfd/linker.c
> > @@ -599,6 +599,7 @@ bfd_wrapped_link_hash_lookup (bfd *abfd,
> >         n[1] = '\0';
> >         strcat (n, l + sizeof REAL - 1);
> >         h = bfd_link_hash_lookup (info->hash, n, create, true, follow);
> > +       h->ref_real = 1;
> >         free (n);
> >         return h;
> >       }
>
> Do you need "if (h != NULL)" here before setting ref_real?  I suspect
> you do.
>

You are right.  I am checking in this.

Thanks.

-- 
H.J.

[-- Attachment #2: 0001-bfd-Check-NULL-pointer-before-setting-ref_real.patch --]
[-- Type: text/x-patch, Size: 796 bytes --]

From 1accb102b68c2fdeaec487f44a18adb14f0c5b12 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Wed, 4 May 2022 17:00:15 -0700
Subject: [PATCH] bfd: Check NULL pointer before setting ref_real

	PR ld/29086
	* linker.c (bfd_wrapped_link_hash_lookup): Check NULL pointer
	before setting ref_real.
---
 bfd/linker.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/bfd/linker.c b/bfd/linker.c
index e9ebdbad040..0c2e3c10a67 100644
--- a/bfd/linker.c
+++ b/bfd/linker.c
@@ -599,7 +599,8 @@ bfd_wrapped_link_hash_lookup (bfd *abfd,
 	  n[1] = '\0';
 	  strcat (n, l + sizeof REAL - 1);
 	  h = bfd_link_hash_lookup (info->hash, n, create, true, follow);
-	  h->ref_real = 1;
+	  if (h != NULL)
+	    h->ref_real = 1;
 	  free (n);
 	  return h;
 	}
-- 
2.35.1