From: "H.J. Lu" <hjl.tools@gmail.com>
To: Alan Modra <amodra@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH 2/4] PR28824, relro security issues, x86 keep COMMONPAGESIZE relro
Date: Sun, 13 Feb 2022 19:13:27 -0800 [thread overview]
Message-ID: <CAMe9rOrQi_MZ4BWzkwECuQLCk4-X0FgRG-G9Yo8t14k3bPCsvQ@mail.gmail.com> (raw)
In-Reply-To: <Ygm75J+479WIuEiB@squeak.grove.modra.org>
On Sun, Feb 13, 2022 at 6:18 PM Alan Modra <amodra@gmail.com> wrote:
>
> On Tue, Feb 08, 2022 at 11:38:31AM +1030, Alan Modra wrote:
> > x86 treats MAXPAGESIZE as a memory optimisation parameter, actual
> > hardware paging is always COMMPAGESIZE of 4k. Use COMMONPAGESIZE for
> > the end of the relro segment alignment.
>
> HJ, you may like to revert this patch and make x86 also align the end
> of the relro segment to MAXPAGESIZE. That's why I extracted this part
> into a separate patch. I'm not anywhere near 100% sure about my claim
> that x86 always uses (or can use) 4k hardware memory pages.
I will take a look tomorrow.
Thanks.
--
H.J.
next prev parent reply other threads:[~2022-02-14 3:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 1:08 [PATCH 0/4] PR28824, relro security issues Alan Modra
2022-02-08 1:08 ` [PATCH 1/4] " Alan Modra
2022-02-08 1:08 ` [PATCH 2/4] PR28824, relro security issues, x86 keep COMMONPAGESIZE relro Alan Modra
2022-02-14 2:18 ` Alan Modra
2022-02-14 3:13 ` H.J. Lu [this message]
2022-02-08 1:08 ` [PATCH 3/4] Remove bfd ELF_RELROPAGESIZE Alan Modra
2022-02-08 1:08 ` [PATCH 4/4] Don't pass around expld.dataseg pointer Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOrQi_MZ4BWzkwECuQLCk4-X0FgRG-G9Yo8t14k3bPCsvQ@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).