* [PATCH] x86: drop L1OM special case from disassembler
@ 2022-03-23 17:09 Jan Beulich
2022-03-23 17:49 ` H.J. Lu
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2022-03-23 17:09 UTC (permalink / raw)
To: Binutils
There wasn't any real support anyway: None of the sub-architecture
specific insns were ever supported.
--- a/opcodes/i386-dis.c
+++ b/opcodes/i386-dis.c
@@ -9423,12 +9423,8 @@ print_insn (bfd_vma pc, instr_info *ins)
}
/* The output looks better if we put 7 bytes on a line, since that
- puts most long word instructions on a single line. Use 8 bytes
- for Intel L1OM. */
- if ((ins->info->mach & bfd_mach_l1om) != 0)
- ins->info->bytes_per_line = 8;
- else
- ins->info->bytes_per_line = 7;
+ puts most long word instructions on a single line. */
+ ins->info->bytes_per_line = 7;
ins->info->private_data = &priv;
priv.max_fetched = priv.the_buffer;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: drop L1OM special case from disassembler
2022-03-23 17:09 [PATCH] x86: drop L1OM special case from disassembler Jan Beulich
@ 2022-03-23 17:49 ` H.J. Lu
0 siblings, 0 replies; 2+ messages in thread
From: H.J. Lu @ 2022-03-23 17:49 UTC (permalink / raw)
To: Jan Beulich; +Cc: Binutils
On Wed, Mar 23, 2022 at 10:09 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> There wasn't any real support anyway: None of the sub-architecture
> specific insns were ever supported.
>
> --- a/opcodes/i386-dis.c
> +++ b/opcodes/i386-dis.c
> @@ -9423,12 +9423,8 @@ print_insn (bfd_vma pc, instr_info *ins)
> }
>
> /* The output looks better if we put 7 bytes on a line, since that
> - puts most long word instructions on a single line. Use 8 bytes
> - for Intel L1OM. */
> - if ((ins->info->mach & bfd_mach_l1om) != 0)
> - ins->info->bytes_per_line = 8;
> - else
> - ins->info->bytes_per_line = 7;
> + puts most long word instructions on a single line. */
> + ins->info->bytes_per_line = 7;
>
> ins->info->private_data = &priv;
> priv.max_fetched = priv.the_buffer;
>
OK.
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-23 17:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-23 17:09 [PATCH] x86: drop L1OM special case from disassembler Jan Beulich
2022-03-23 17:49 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).