From: Dmitry Selyutin <ghostmansd@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: lkcl <luke.leighton@gmail.com>,
Binutils <binutils@sourceware.org>,
Alan Modra <amodra@gmail.com>
Subject: Re: Teaching expression() to treat some operations specially
Date: Tue, 12 Jul 2022 09:58:15 +0300 [thread overview]
Message-ID: <CAMqzjetppzPZtVrAscxwq400nfJqfYE7_wer=2QbQ_wr-ugoNQ@mail.gmail.com> (raw)
In-Reply-To: <473de1ae-ab00-357c-56e1-a12e2eab779a@suse.com>
On Tue, Jul 12, 2022 at 9:25 AM Jan Beulich <jbeulich@suse.com> wrote:
> May I ask which other struct fields are consumed and where? It is
> my understanding that for O_register other fields simply are
> invalid ...
Also, it seems a bit strange that, instead of providing md_operand, we
rather try to parse with a custom routine, register_name:
https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gas/config/tc-ppc.c;h=5015777d60061e61ffe4c78591b793862919c769;hb=HEAD#l3444
I'd rather expect we have this logic in md_operand.
We could avoid duplicating some bits in ppc_parse_name.
Also, this way, we would cover macros as well, which we don't do now.
--
Best regards,
Dmitry Selyutin
prev parent reply other threads:[~2022-07-12 6:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 16:47 Dmitry Selyutin
2022-07-11 1:01 ` Alan Modra
2022-07-11 2:33 ` lkcl
2022-07-11 3:08 ` Alan Modra
2022-07-11 14:28 ` Dmitry Selyutin
2022-07-11 19:13 ` Dmitry Selyutin
2022-07-11 23:37 ` Alan Modra
2022-07-12 4:18 ` Dmitry Selyutin
2022-07-12 6:25 ` Jan Beulich
2022-07-12 6:47 ` Dmitry Selyutin
2022-07-12 6:57 ` Jan Beulich
2022-07-12 8:50 ` Dmitry Selyutin
2022-07-12 10:44 ` Jan Beulich
2022-07-12 11:17 ` Dmitry Selyutin
2022-07-12 11:39 ` Jan Beulich
2022-07-12 9:01 ` Dmitry Selyutin
2022-07-12 6:58 ` Dmitry Selyutin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMqzjetppzPZtVrAscxwq400nfJqfYE7_wer=2QbQ_wr-ugoNQ@mail.gmail.com' \
--to=ghostmansd@gmail.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
--cc=luke.leighton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).