From: Dmitry Selyutin <ghostmansd@gmail.com>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org,
Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Subject: Re: [PATCH 1/2] ppc: extend opindex to 16 bits
Date: Thu, 12 May 2022 10:41:24 +0300 [thread overview]
Message-ID: <CAMqzjevvtL+8XKjivH6omosqy1Ro2nN-=h_3-K6huCNBFf1Ggw@mail.gmail.com> (raw)
In-Reply-To: <YnxRQvTqbbnLC1JA@squeak.grove.modra.org>
On Thu, May 12, 2022 at 3:13 AM Alan Modra <amodra@gmail.com> wrote:
> Huh? What makes you say that?
That was my first impression, since the only negative value I found
was -1, and I initially thought that was just a placeholder value.
Thank you for noticing that! I changed the wording so that we only
stress that this is signed and (for now?) 16-bit.
> Also, your patch misses changing the following. The existing 0xff
> mask was from a time when fx_pcrel_adjust was a signed char.
>
> int opindex = fixP->fx_pcrel_adjust & 0xff;
>
> This could be any of
> int opindex = fixP->fx_pcrel_adjust & 0xffff;
> int opindex = (uint16_t) fixP->fx_pcrel_adjust;
> uint16_t opindex = fixP->fx_pcrel_adjust;
> Which you choose is a matter of style.
Thank you! Since PPC code now has the typedef, I updated the patch to
use `(ppc_opindex_t)fixP->fx_pcrel_adjust` form.
prev parent reply other threads:[~2022-05-12 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 17:59 Dmitry Selyutin
2022-05-12 0:13 ` Alan Modra
2022-05-12 7:41 ` Dmitry Selyutin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMqzjevvtL+8XKjivH6omosqy1Ro2nN-=h_3-K6huCNBFf1Ggw@mail.gmail.com' \
--to=ghostmansd@gmail.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=lkcl@lkcl.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).