From: Alan Modra <amodra@gmail.com>
To: Dmitry Selyutin <ghostmansd@gmail.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org,
Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Subject: Re: [PATCH 1/2] ppc: extend opindex to 16 bits
Date: Thu, 12 May 2022 09:43:54 +0930 [thread overview]
Message-ID: <YnxRQvTqbbnLC1JA@squeak.grove.modra.org> (raw)
In-Reply-To: <CAMqzjev0a5YLn24QEV1k1yvH_tCxuxHLSt4G7_xYMLEeYsoHJQ@mail.gmail.com>
On Wed, May 11, 2022 at 08:59:19PM +0300, Dmitry Selyutin wrote:
> + Also, this field is signed due to historical reasons. */
Huh? What makes you say that?
Also, your patch misses changing the following. The existing 0xff
mask was from a time when fx_pcrel_adjust was a signed char.
int opindex = fixP->fx_pcrel_adjust & 0xff;
This could be any of
int opindex = fixP->fx_pcrel_adjust & 0xffff;
int opindex = (uint16_t) fixP->fx_pcrel_adjust;
uint16_t opindex = fixP->fx_pcrel_adjust;
Which you choose is a matter of style.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2022-05-12 0:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 17:59 Dmitry Selyutin
2022-05-12 0:13 ` Alan Modra [this message]
2022-05-12 7:41 ` Dmitry Selyutin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnxRQvTqbbnLC1JA@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=ghostmansd@gmail.com \
--cc=lkcl@lkcl.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).