Re: [PATCH] wwwdocs: contribute.html: Update consensus on patch content.

Re: [PATCH] wwwdocs: contribute.html: Update consensus on patch content.

[Christophe Lyon]

On Fri, 26 Apr 2024 at 10:25, Christophe Lyon
<christophe.lyon@linaro.org> wrote:
>
> On Thu, 25 Apr 2024 at 17:44, Carlos O'Donell <carlos@redhat.com> wrote:
> >
> > Discussion is here:
> > https://inbox.sourceware.org/gcc/CAPS5khZeWkAD=V8ka9g5eECDNK3BDHFNZJuMpVC+HeDmkVJMCg@mail.gmail.com/
> >
> > Rough consensus from Jakub Jelinek, Richard Biener and others is
> > that maintainers are for the change.
> >
> > This changes the contribution notes to allow it.
>
> Thank you Carlos for the patch and helping with the discussions!
>
> Christophe
>

And BTW sorry I wasn't able to attend the meeting yesterday, thanks
Thiago for raising the question.

I have a follow-up one: I think the same applies to binutils, but I
don't think any maintainer / contributor expressed an opinion, and
IIUC patch policy for binutils is (lightly) documented at
https://sourceware.org/binutils/wiki/HowToContribute
Maybe Nick can update it? (I don't have such rights)

Thanks,

Christophe

> > ---
> >  htdocs/contribute.html | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/htdocs/contribute.html b/htdocs/contribute.html
> > index 7c1ae323..e8137edc 100644
> > --- a/htdocs/contribute.html
> > +++ b/htdocs/contribute.html
> > @@ -195,8 +195,9 @@ of your testing.
> >
> >  <dt>The patch itself</dt>
> >  <dd>
> > -Do not include generated files as part of the patch, just mention
> > -them in the ChangeLog (e.g., "<code>* configure: Regenerate.</code>").
> > +The patch should include everything you are changing (including
> > +regenerated files which should be noted in the ChangeLog e.g.
> > +"<code>* configure: Regenerate.</code>").
> >  </dd>
> >
> >  </dl>
> > --
> > 2.44.0
> >