From: Nelson Chu <nelson@rivosinc.com>
To: Christoph Muellner <christoph.muellner@vrull.eu>
Cc: binutils@sourceware.org, Nathan Huckleberry <nhuck@google.com>,
nhuck@pmull.org, Jeff Law <jeffreyalaw@gmail.com>,
Andrew Waterman <andrew@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>
Subject: Re: [PATCH v6 05/15] RISC-V: Add support for the Zvknh[a,b] ISA extensions
Date: Mon, 3 Jul 2023 17:47:41 +0800 [thread overview]
Message-ID: <CAPpQWtBPVBdeOw=pVkWi2othLHqhKoji2A=g8uvGA19RmDenvw@mail.gmail.com> (raw)
In-Reply-To: <20230701052104.4018352-6-christoph.muellner@vrull.eu>
[-- Attachment #1: Type: text/plain, Size: 8643 bytes --]
On Sat, Jul 1, 2023 at 1:21 PM Christoph Muellner <
christoph.muellner@vrull.eu> wrote:
> From: Christoph Müllner <christoph.muellner@vrull.eu>
>
> Zvknh[a,b] are parts of the vector crypto extensions.
>
> This extension adds the following instructions:
> - vsha2ms.vv
> - vsha2c[hl].vv
>
> bfd/ChangeLog:
>
> * elfxx-riscv.c (riscv_multi_subset_supports): Add instruction
> class support for Zvknh[a,b].
> (riscv_multi_subset_supports_ext): Likewise.
>
> gas/ChangeLog:
>
> * testsuite/gas/riscv/zvknha.d: New test.
> * testsuite/gas/riscv/zvknha_zvknhb.s: New test.
> * testsuite/gas/riscv/zvknhb.d: New test.
>
> include/ChangeLog:
>
> * opcode/riscv-opc.h (MATCH_VSHA2CH_VV): New.
> (MASK_VSHA2CH_VV): New.
> (MATCH_VSHA2CL_VV): New.
> (MASK_VSHA2CL_VV): New.
> (MATCH_VSHA2MS_VV): New.
> (MASK_VSHA2MS_VV): New.
> (DECLARE_INSN): New.
> * opcode/riscv.h (enum riscv_insn_class): Add instruction class
> support for Zvknh[a,b].
>
> opcodes/ChangeLog:
>
> * riscv-opc.c: Add Zvknh[a,b] instructions.
>
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
> Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
> ---
> bfd/elfxx-riscv.c | 13 +++++++++++++
> gas/testsuite/gas/riscv/zvknha.d | 12 ++++++++++++
> gas/testsuite/gas/riscv/zvknha_zvknhb.s | 3 +++
> gas/testsuite/gas/riscv/zvknhb.d | 12 ++++++++++++
> include/opcode/riscv-opc.h | 11 +++++++++++
> include/opcode/riscv.h | 3 +++
> opcodes/riscv-opc.c | 5 +++++
> 7 files changed, 59 insertions(+)
> create mode 100644 gas/testsuite/gas/riscv/zvknha.d
> create mode 100644 gas/testsuite/gas/riscv/zvknha_zvknhb.s
> create mode 100644 gas/testsuite/gas/riscv/zvknhb.d
>
> diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
> index be8d956f316..696b5c10147 100644
> --- a/bfd/elfxx-riscv.c
> +++ b/bfd/elfxx-riscv.c
> @@ -1266,6 +1266,8 @@ static struct riscv_supported_ext
> riscv_supported_std_z_ext[] =
> {"zvbc", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> {"zvkg", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> {"zvkned", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> + {"zvknha", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> + {"zvknhb", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> {"zvl32b", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> {"zvl64b", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> {"zvl128b", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 },
> @@ -2439,6 +2441,13 @@ riscv_multi_subset_supports (riscv_parse_subset_t
> *rps,
> return riscv_subset_supports (rps, "zvkg");
> case INSN_CLASS_ZVKNED:
> return riscv_subset_supports (rps, "zvkned");
> + case INSN_CLASS_ZVKNHA:
> + return riscv_subset_supports (rps, "zvknha");
> + case INSN_CLASS_ZVKNHB:
> + return riscv_subset_supports (rps, "zvknhb");
> + case INSN_CLASS_ZVKNHA_OR_ZVKNHB:
> + return (riscv_subset_supports (rps, "zvknha")
> + || riscv_subset_supports (rps, "zvknhb"));
>
Looks like we only have INSN_CLASS_ZVKNHA_OR_ZVKNHB in the opcode table, so
INSN_CLASS_ZVKNHA and INSN_CLASS_ZVKNHB are redundant here.
> case INSN_CLASS_SVINVAL:
> return riscv_subset_supports (rps, "svinval");
> case INSN_CLASS_H:
> @@ -2635,6 +2644,10 @@ riscv_multi_subset_supports_ext
> (riscv_parse_subset_t *rps,
> return _("zvkg");
> case INSN_CLASS_ZVKNED:
> return _("zvkned");
> + case INSN_CLASS_ZVKNHA:
> + return _("zvknha");
> + case INSN_CLASS_ZVKNHB:
> + return _("zvknhb");
>
Likewise, the INSN_CLASS_ZVKNHA_OR_ZVKNHB define is lost, so I guess it
will return an unreachable INSN_CLASS_* internal error.
> case INSN_CLASS_SVINVAL:
> return "svinval";
> case INSN_CLASS_H:
> diff --git a/gas/testsuite/gas/riscv/zvknha.d
> b/gas/testsuite/gas/riscv/zvknha.d
> new file mode 100644
> index 00000000000..36d660f634f
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/zvknha.d
> @@ -0,0 +1,12 @@
> +#as: -march=rv64gc_zvknha
> +#source: zvknha_zvknhb.s
> +#objdump: -dr
> +
> +.*:[ ]+file format .*
> +
> +
> +Disassembly of section .text:
> +0+000 <.text>:
> +[ ]+[0-9a-f]+:[ ]+ba862277[ ]+vsha2ch.vv[ ]+v4,v8,v12
> +[ ]+[0-9a-f]+:[ ]+be862277[ ]+vsha2cl.vv[ ]+v4,v8,v12
> +[ ]+[0-9a-f]+:[ ]+b6862277[ ]+vsha2ms.vv[ ]+v4,v8,v12
> diff --git a/gas/testsuite/gas/riscv/zvknha_zvknhb.s
> b/gas/testsuite/gas/riscv/zvknha_zvknhb.s
> new file mode 100644
> index 00000000000..d20e6310531
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/zvknha_zvknhb.s
> @@ -0,0 +1,3 @@
> + vsha2ch.vv v4, v8, v12
> + vsha2cl.vv v4, v8, v12
> + vsha2ms.vv v4, v8, v12
> diff --git a/gas/testsuite/gas/riscv/zvknhb.d
> b/gas/testsuite/gas/riscv/zvknhb.d
> new file mode 100644
> index 00000000000..ab0f035889e
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/zvknhb.d
> @@ -0,0 +1,12 @@
> +#as: -march=rv64gc_zvknhb
> +#source: zvknha_zvknhb.s
> +#objdump: -dr
> +
> +.*:[ ]+file format .*
> +
> +
> +Disassembly of section .text:
> +0+000 <.text>:
> +[ ]+[0-9a-f]+:[ ]+ba862277[ ]+vsha2ch.vv[ ]+v4,v8,v12
> +[ ]+[0-9a-f]+:[ ]+be862277[ ]+vsha2cl.vv[ ]+v4,v8,v12
> +[ ]+[0-9a-f]+:[ ]+b6862277[ ]+vsha2ms.vv[ ]+v4,v8,v12
> diff --git a/include/opcode/riscv-opc.h b/include/opcode/riscv-opc.h
> index b8c3834b819..95c4188d084 100644
> --- a/include/opcode/riscv-opc.h
> +++ b/include/opcode/riscv-opc.h
> @@ -2191,6 +2191,13 @@
> #define MASK_VAESKF2_VI 0xfe00707f
> #define MATCH_VAESZ_VS 0xa603a077
> #define MASK_VAESZ_VS 0xfe0ff07f
> +/* Zvknh[a,b] instructions. */
> +#define MATCH_VSHA2CH_VV 0xba002077
> +#define MASK_VSHA2CH_VV 0xfe00707f
> +#define MATCH_VSHA2CL_VV 0xbe002077
> +#define MASK_VSHA2CL_VV 0xfe00707f
> +#define MATCH_VSHA2MS_VV 0xb6002077
> +#define MASK_VSHA2MS_VV 0xfe00707f
> /* Svinval instruction. */
> #define MATCH_SINVAL_VMA 0x16000073
> #define MASK_SINVAL_VMA 0xfe007fff
> @@ -3337,6 +3344,10 @@ DECLARE_INSN(vaesem_vv, MATCH_VAESEM_VV,
> MASK_VAESEM_VV)
> DECLARE_INSN(vaeskf1_vi, MATCH_VAESKF1_VI, MASK_VAESKF1_VI)
> DECLARE_INSN(vaeskf2_vi, MATCH_VAESKF2_VI, MASK_VAESKF2_VI)
> DECLARE_INSN(vaesz_vs, MATCH_VAESZ_VS, MASK_VAESZ_VS)
> +/* Zvknh[a,b] instructions. */
> +DECLARE_INSN(vsha2ch_vv, MATCH_VSHA2CH_VV, MASK_VSHA2CH_VV)
> +DECLARE_INSN(vsha2cl_vv, MATCH_VSHA2CL_VV, MASK_VSHA2CL_VV)
> +DECLARE_INSN(vsha2ms_vv, MATCH_VSHA2MS_VV, MASK_VSHA2MS_VV)
> /* Vendor-specific (T-Head) XTheadBa instructions. */
> DECLARE_INSN(th_addsl, MATCH_TH_ADDSL, MASK_TH_ADDSL)
> /* Vendor-specific (T-Head) XTheadBb instructions. */
> diff --git a/include/opcode/riscv.h b/include/opcode/riscv.h
> index 5d55dbcedf3..77207ea79b2 100644
> --- a/include/opcode/riscv.h
> +++ b/include/opcode/riscv.h
> @@ -418,6 +418,9 @@ enum riscv_insn_class
> INSN_CLASS_ZVBC,
> INSN_CLASS_ZVKG,
> INSN_CLASS_ZVKNED,
> + INSN_CLASS_ZVKNHA,
> + INSN_CLASS_ZVKNHB,
>
Likewise.
> + INSN_CLASS_ZVKNHA_OR_ZVKNHB,
> INSN_CLASS_SVINVAL,
> INSN_CLASS_ZICBOM,
> INSN_CLASS_ZICBOP,
> diff --git a/opcodes/riscv-opc.c b/opcodes/riscv-opc.c
> index 175cf5cc94f..297fda85af5 100644
> --- a/opcodes/riscv-opc.c
> +++ b/opcodes/riscv-opc.c
> @@ -1925,6 +1925,11 @@ const struct riscv_opcode riscv_opcodes[] =
> {"vaeskf2.vi", 0, INSN_CLASS_ZVKNED, "Vd,Vt,Vj", MATCH_VAESKF2_VI,
> MASK_VAESKF2_VI, match_opcode, 0},
> {"vaesz.vs", 0, INSN_CLASS_ZVKNED, "Vd,Vt", MATCH_VAESZ_VS,
> MASK_VAESZ_VS, match_opcode, 0},
>
> +/* Zvknh[a,b] instructions. */
> +{"vsha2ch.vv", 0, INSN_CLASS_ZVKNHA_OR_ZVKNHB, "Vd,Vt,Vs",
> MATCH_VSHA2CH_VV, MASK_VSHA2CH_VV, match_opcode, 0},
> +{"vsha2cl.vv", 0, INSN_CLASS_ZVKNHA_OR_ZVKNHB, "Vd,Vt,Vs",
> MATCH_VSHA2CL_VV, MASK_VSHA2CL_VV, match_opcode, 0},
> +{"vsha2ms.vv", 0, INSN_CLASS_ZVKNHA_OR_ZVKNHB, "Vd,Vt,Vs",
> MATCH_VSHA2MS_VV, MASK_VSHA2MS_VV, match_opcode, 0},
> +
> /* Supervisor instructions. */
> {"csrr", 0, INSN_CLASS_ZICSR, "d,E", MATCH_CSRRS,
> MASK_CSRRS|MASK_RS1, match_opcode, INSN_ALIAS },
> {"csrw", 0, INSN_CLASS_ZICSR, "E,s", MATCH_CSRRW,
> MASK_CSRRW|MASK_RD, match_opcode, INSN_ALIAS },
> --
> 2.41.0
>
>
next prev parent reply other threads:[~2023-07-03 9:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-01 5:20 [PATCH v6 00/15] RISC-V: Add support for vector crypto extensions Christoph Muellner
2023-07-01 5:20 ` [PATCH v6 01/15] RISC-V: Add support for the Zvbb ISA extension Christoph Muellner
2023-07-01 5:20 ` [PATCH v6 02/15] RISC-V: Add support for the Zvbc extension Christoph Muellner
2023-07-17 7:02 ` Jan Beulich
2023-07-17 7:11 ` Philipp Tomsich
2023-07-17 7:26 ` Jan Beulich
2023-07-17 7:28 ` Philipp Tomsich
2023-07-17 7:20 ` Christoph Müllner
2023-07-24 21:12 ` [CAUTION - External Sender] " Ken Dockser
2023-07-01 5:20 ` [PATCH v6 03/15] RISC-V: Add support for the Zvkg ISA extension Christoph Muellner
2023-07-24 7:14 ` Jan Beulich
2023-07-01 5:20 ` [PATCH v6 04/15] RISC-V: Add support for the Zvkned " Christoph Muellner
2023-07-01 5:20 ` [PATCH v6 05/15] RISC-V: Add support for the Zvknh[a,b] ISA extensions Christoph Muellner
2023-07-03 9:47 ` Nelson Chu [this message]
2023-07-03 10:10 ` Christoph Müllner
2023-07-01 5:20 ` [PATCH v6 06/15] RISC-V: Add support for the Zvksed ISA extension Christoph Muellner
2023-07-01 5:20 ` [PATCH v6 07/15] RISC-V: Add support for the Zvksh " Christoph Muellner
2023-07-01 5:20 ` [PATCH v6 08/15] RISC-V: Add support for the Zvkn " Christoph Muellner
2023-07-01 5:20 ` [PATCH v6 09/15] RISC-V: Allow nested implications for extensions Christoph Muellner
2023-07-01 5:20 ` [PATCH v6 10/15] RISC-V: Add support for the Zvkng ISA extension Christoph Muellner
2023-07-01 5:21 ` [PATCH v6 11/15] RISC-V: Add support for the Zvks " Christoph Muellner
2023-07-01 5:21 ` [PATCH v6 12/15] RISC-V: Add support for the Zvksg " Christoph Muellner
2023-07-01 5:21 ` [PATCH v6 13/15] RISC-V: Add support for the Zvknc " Christoph Muellner
2023-07-01 5:21 ` [PATCH v6 14/15] RISC-V: Add support for the Zvksc " Christoph Muellner
2023-07-01 5:21 ` [PATCH v6 15/15] binutils: NEWS: Announce new RISC-V vector crypto extensions Christoph Muellner
2023-07-01 13:38 ` [PATCH v6 00/15] RISC-V: Add support for " Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPpQWtBPVBdeOw=pVkWi2othLHqhKoji2A=g8uvGA19RmDenvw@mail.gmail.com' \
--to=nelson@rivosinc.com \
--cc=andrew@sifive.com \
--cc=binutils@sourceware.org \
--cc=christoph.muellner@vrull.eu \
--cc=jeffreyalaw@gmail.com \
--cc=jim.wilson.gcc@gmail.com \
--cc=nhuck@google.com \
--cc=nhuck@pmull.org \
--cc=palmer@dabbelt.com \
--cc=philipp.tomsich@vrull.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).