Re: [REVIEW ONLY 0/2] NEAR RATIFICATION RISC-V: Extensions from the RISC-V Profiles

[Nelson Chu <nelson@rivosinc.com>]

On Thu, Nov 3, 2022 at 8:26 PM Tsukasa OI <research_trasio@irq.a4lg.com> wrote:
>
> Hello,
>
> This patchset implements all extensions from RISC-V Profiles (but not
> profile itself).  I'm not sure whether this patchset helps someone
> implementing RISC-V Profiles but I hope so.
>
> Thanks,
> Tsukasa
>
>
>
>
> Tsukasa OI (2):
>   NEAR-RATIFICATION RISC-V: Add 'Ssstateen' extension and its CSRs

Looks good.

>   NEAR-RATIFICATION RISC-V: Add platform property/capability extensions

If we just need to recognize them in assembler, then it looks good.
Thanks for arranging these bunch of extensions before everything gets
messy...  Generally, since they are frozen, we have good reason to
commit them to the mainline.  But if you prefer to wait until they are
ratified, then that's also work to me, I believe you know when will be
the best time, so please commit at that time.

Thanks
Nelson

Nelson

>  bfd/elfxx-riscv.c                           | 38 +++++++++++++++-
>  gas/config/tc-riscv.c                       | 20 +++++----
>  gas/testsuite/gas/riscv/csr-version-1p10.l  | 48 ++++++++++-----------
>  gas/testsuite/gas/riscv/csr-version-1p11.l  | 48 ++++++++++-----------
>  gas/testsuite/gas/riscv/csr-version-1p12.l  | 48 ++++++++++-----------
>  gas/testsuite/gas/riscv/csr-version-1p9p1.l | 48 ++++++++++-----------
>  gas/testsuite/gas/riscv/csr.s               |  2 +-
>  gas/testsuite/gas/riscv/smstateen-csr-s.d   | 22 ++++++++++
>  gas/testsuite/gas/riscv/ssstateen-csr.d     | 22 ++++++++++
>  gas/testsuite/gas/riscv/ssstateen-csr.s     | 13 ++++++
>  include/opcode/riscv-opc.h                  | 26 +++++------
>  11 files changed, 215 insertions(+), 120 deletions(-)
>  create mode 100644 gas/testsuite/gas/riscv/smstateen-csr-s.d
>  create mode 100644 gas/testsuite/gas/riscv/ssstateen-csr.d
>  create mode 100644 gas/testsuite/gas/riscv/ssstateen-csr.s
>
>
> base-commit: ae1c45ead6b60ef0fd338bbeb6a4c5e5808c6e6a
> --
> 2.37.2
>