From: Nelson Chu <nelson@rivosinc.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Binutils <binutils@sourceware.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Andrew Waterman <andrew@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>
Subject: Re: [PATCH] RISC-V: as_warn() already emits a newline
Date: Mon, 20 Feb 2023 10:46:10 +0800 [thread overview]
Message-ID: <CAPpQWtCn=Le5-s5PLBRaHVBcbbee4FELir5Wtzp4aFfSrv=_mg@mail.gmail.com> (raw)
In-Reply-To: <f055cbdb-e706-3a74-ab63-725ed8a047fd@suse.com>
OK, thanks for fixing this.
Nelson
On Thu, Feb 16, 2023 at 4:56 PM Jan Beulich <jbeulich@suse.com> wrote:
>
> Therefore there shouldn't be any at the end of the format string.
>
> --- a/gas/config/tc-riscv.c
> +++ b/gas/config/tc-riscv.c
> @@ -4179,7 +4179,7 @@ s_riscv_option (int x ATTRIBUTE_UNUSED)
> }
> else
> {
> - as_warn (_("unrecognized .option directive: %s\n"), name);
> + as_warn (_("unrecognized .option directive: %s"), name);
> }
> *input_line_pointer = ch;
> demand_empty_rest_of_line ();
prev parent reply other threads:[~2023-02-20 10:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 8:56 Jan Beulich
2023-02-20 2:46 ` Nelson Chu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPpQWtCn=Le5-s5PLBRaHVBcbbee4FELir5Wtzp4aFfSrv=_mg@mail.gmail.com' \
--to=nelson@rivosinc.com \
--cc=andrew@sifive.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
--cc=jim.wilson.gcc@gmail.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).