From: Nelson Chu <nelson@rivosinc.com>
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 1/2] gas: RISC-V: Add a test for near->far branch conversion
Date: Tue, 31 Jan 2023 11:37:53 +0800 [thread overview]
Message-ID: <CAPpQWtD6SCyrG+CGPk4PDAAEgA3EP7sCeA+2yP2672vPgovQ-A@mail.gmail.com> (raw)
In-Reply-To: <20230130210642.7579-1-palmer@rivosinc.com>
I always thought the test cases were already there, because the
assembler branch relaxation (or branch conversion, whatever called)
has been supported since the very beginning of the risc-v porting.
Anyway, both of the gas and ld test cases for this are what we need,
so thanks for adding them :)
Nelson
On Tue, Jan 31, 2023 at 5:07 AM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>
> This works in GAS and has for a very long time, but I couldn't find a
> test case for it. It doesn't appear to be documented anywhere, but GCC
> depends on it and I'd bet a bunch of handwritten assembly does too so
> it's probably too late to drop.
> ---
> gas/testsuite/gas/riscv/far-branch.d | 13 +++++++++++++
> gas/testsuite/gas/riscv/far-branch.s | 6 ++++++
> 2 files changed, 19 insertions(+)
> create mode 100644 gas/testsuite/gas/riscv/far-branch.d
> create mode 100644 gas/testsuite/gas/riscv/far-branch.s
>
> diff --git a/gas/testsuite/gas/riscv/far-branch.d b/gas/testsuite/gas/riscv/far-branch.d
> new file mode 100644
> index 00000000000..e781e3eadb5
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/far-branch.d
> @@ -0,0 +1,13 @@
> +#as: -march=rv32i
> +#objdump: -d
> +
> +.*:[ ]+file format .*
> +
> +
> +Disassembly of section .text:
> +
> +0+000 <target>:
> +[^:]+:[ ]+00b51063[ ]+bne[ ]+a0,a1,0 <target>
> +#...
> +[^:]+:[ ]+00b50463[ ]+beq[ ]+a0,a1,.*
> +[^:]+:[ ]+ff9fe06f[ ]+j[ ]+0 <target>
> diff --git a/gas/testsuite/gas/riscv/far-branch.s b/gas/testsuite/gas/riscv/far-branch.s
> new file mode 100644
> index 00000000000..2b369ffb538
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/far-branch.s
> @@ -0,0 +1,6 @@
> +target:
> + bne a0, a1, target
> +.rep 1024
> + nop
> +.endr
> + bne a0, a1, target
> --
> 2.39.0
>
next prev parent reply other threads:[~2023-01-31 3:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 21:06 Palmer Dabbelt
2023-01-30 21:06 ` [PATCH 2/2] ld: RISC-V: Test R_RISCV_BRANCH truncation errors Palmer Dabbelt
2023-01-31 3:37 ` Nelson Chu [this message]
2023-01-31 8:57 ` [PATCH 1/2] gas: RISC-V: Add a test for near->far branch conversion Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPpQWtD6SCyrG+CGPk4PDAAEgA3EP7sCeA+2yP2672vPgovQ-A@mail.gmail.com \
--to=nelson@rivosinc.com \
--cc=binutils@sourceware.org \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).