From: Nelson Chu <nelson@rivosinc.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Christoph Muellner <christoph.muellner@vrull.eu>,
binutils@sourceware.org, Andrew Waterman <andrew@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>
Subject: Re: [PATCH] RISC-V: Eliminate long-casts of X_add_number in diagnostics
Date: Fri, 30 Sep 2022 22:45:58 +0800 [thread overview]
Message-ID: <CAPpQWtDBm+0zcV9NfCcCnrq5aW3=oaiBjnuoYL4=ckrOdPGCVQ@mail.gmail.com> (raw)
In-Reply-To: <00331db1-f209-e4bb-ae15-4501ad59ce5e@suse.com>
Both approved, please commit. Thanks for helping to fix them.
Nelson
On Fri, Sep 30, 2022 at 6:46 PM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 30.09.2022 12:39, Christoph Muellner wrote:
> > From: Christoph Müllner <christoph.muellner@vrull.eu>
> >
> > As reported in (and in addition to)
> > https://sourceware.org/pipermail/binutils/2022-September/123198.html
> > there is no need for casts to (signed/unsigned) long, as we can use
> > C99's PRIs64/PRIu64 format specifiers.
>
> For archaeologists you may want to s/PRIs64/PRId64/, such that no-one
> will be misguided. Otherwise thanks for taking care of the other items
> this quickly. I'll leave approving of this (as well as my earlier
> patch) to the arch maintainers, though.
>
> Jan
next prev parent reply other threads:[~2022-09-30 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 10:39 Christoph Muellner
2022-09-30 10:46 ` Jan Beulich
2022-09-30 14:45 ` Nelson Chu [this message]
2022-09-30 14:55 ` Philipp Tomsich
2022-09-30 19:26 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPpQWtDBm+0zcV9NfCcCnrq5aW3=oaiBjnuoYL4=ckrOdPGCVQ@mail.gmail.com' \
--to=nelson@rivosinc.com \
--cc=andrew@sifive.com \
--cc=binutils@sourceware.org \
--cc=christoph.muellner@vrull.eu \
--cc=jbeulich@suse.com \
--cc=jim.wilson.gcc@gmail.com \
--cc=palmer@dabbelt.com \
--cc=philipp.tomsich@vrull.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).