public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Tan Yuan <tanyuan@tinylab.org>
To: xry111@xry111.site
Cc: falcon@tinylab.org, binutils@sourceware.org
Subject: Re: [PATCH 0/1] gas: add new command line option --no-group-check
Date: Sun, 23 Jul 2023 17:31:39 +0800	[thread overview]
Message-ID: <CFDD2D31A765CC98+20230723093139.3730537-1-tanyuan@tinylab.org> (raw)
In-Reply-To: <36ddb62827e935470fe09487e78142128641816b.camel@xry111.site>

Hi,

> On Sat, 2023-07-22 at 11:47 +0800, Tan Yuan wrote:
> > 
> > We hope to modify code like this in the kernel:
> > +   #define ___PASTE(a,b) a##b
> > +   #define __PASTE(a,b) ___PASTE(a,b)
> > +   #define __UNIQUE_ID_GROUP __PASTE(__PASTE(__COUNTER__, _),
> > __LINE__)
> >     
> >     #define __ASM_EXTABLE_RAW(insn, fixup, type, data)     \
> > -           ".pushsection   __ex_table, \"a\"\n"            \
> > +           ".attach_to_group " __stringify(__UNIQUE_ID_GROUP) "\n" \
> > +           ".pushsection   __ex_table, \"a?\"\n"           \
> >             "…"                            \
> >             ".popsection\n"
> 
> Note that even if this Binutils patch is accepted, it will only show up
> in Binutils-2.42 and later.  So the kernel maintainers will reject this
> change, as you cannot tell everyone "use Binutils >= 2.42 to build the
> kernel".
> 
> I'd suggest to try figuring out a better solution.
> -- 
> Xi Ruoyao <xry111@xry111.site>
> School of Aerospace Science and Technology, Xidian University

Thanks your suggestion and I really need some new idea to solve this problems.

This method is the best I can come up with so far.  However, I don’t think
"Binutils >= 2.42" is a problem, as what I am adding to kernel is an optional
feature, user can choose to enable it. And it seems that we can check version
of Binutils in the code[1].

[1]: https://stackoverflow.com/a/51008423

Tan Yuan

  reply	other threads:[~2023-07-23  9:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21 15:14 Tan Yuan
2023-07-21 22:55 ` Alan Modra
2023-07-22  3:47   ` Tan Yuan
2023-07-22  3:56     ` Xi Ruoyao
2023-07-23  9:31       ` Tan Yuan [this message]
2023-07-22  0:32 ` Song Fangrui
     [not found] <DS7PR12MB5765A326273E125586D742F7CB3CA@DS7PR12MB5765.namprd12.prod.outlook.com>
2023-07-23  9:10 ` Tan Yuan
2023-07-23 17:15   ` Fangrui Song
2023-07-24  9:28 ` Tan Yuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CFDD2D31A765CC98+20230723093139.3730537-1-tanyuan@tinylab.org \
    --to=tanyuan@tinylab.org \
    --cc=binutils@sourceware.org \
    --cc=falcon@tinylab.org \
    --cc=xry111@xry111.site \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).