From: Alan Modra <amodra@gmail.com>
To: Tan Yuan <tanyuan@tinylab.org>
Cc: binutils@sourceware.org, jbeulich@suse.com
Subject: Re: [PATCH 0/1] gas: add new command line option --no-group-check
Date: Sat, 22 Jul 2023 08:25:35 +0930 [thread overview]
Message-ID: <ZLsM5+PTo2BM3zJ8@squeak.grove.modra.org> (raw)
In-Reply-To: <C46FD19573A4B955+cover.1689950871.git.tanyuan@tinylab.org>
On Fri, Jul 21, 2023 at 11:14:20PM +0800, Tan Yuan wrote:
> Hi, list
>
> This patch introduces a new option that allows suppressing the warning
> when attaching a group to a section that already belongs to a group.
Is this alternative patch sufficient for the kernel usage?
* config/obj-elf.c (obj_elf_attach_to_group): Don't warn if
group name matches current group for section.
diff --git a/gas/config/obj-elf.c b/gas/config/obj-elf.c
index 753a929fb14..dc05b35ee99 100644
--- a/gas/config/obj-elf.c
+++ b/gas/config/obj-elf.c
@@ -1088,8 +1088,9 @@ obj_elf_attach_to_group (int dummy ATTRIBUTE_UNUSED)
if (elf_group_name (now_seg))
{
- as_warn (_("section %s already has a group (%s)"),
- bfd_section_name (now_seg), elf_group_name (now_seg));
+ if (strcmp (elf_group_name (now_seg), gname) != 0)
+ as_warn (_("section %s already has a group (%s)"),
+ bfd_section_name (now_seg), elf_group_name (now_seg));
return;
}
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2023-07-21 22:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 15:14 Tan Yuan
2023-07-21 22:55 ` Alan Modra [this message]
2023-07-22 3:47 ` Tan Yuan
2023-07-22 3:56 ` Xi Ruoyao
2023-07-23 9:31 ` Tan Yuan
2023-07-22 0:32 ` Song Fangrui
[not found] <DS7PR12MB5765A326273E125586D742F7CB3CA@DS7PR12MB5765.namprd12.prod.outlook.com>
2023-07-23 9:10 ` Tan Yuan
2023-07-23 17:15 ` Fangrui Song
2023-07-24 9:28 ` Tan Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLsM5+PTo2BM3zJ8@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
--cc=tanyuan@tinylab.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).